Fix feature flag categorization metadata#57610
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
Summary: Corrects categorization metadata in the feature flags config. These are metadata-only changes: flag default values and runtime behavior are unchanged, and no generated files are affected (the codegen does not consume the `purpose` or `dateAdded` fields). - Zero-pad three malformed `dateAdded` values to the `YYYY-MM-DD` convention (`enableAccessibilityOrder`, `useSharedAnimatedBackend`, `useTraitHiddenOnAndroid`). - Recategorize `enableDoubleMeasurementFixAndroid` as an experimentation flag (adding its `dateAdded`), since it gates a one-off fix that is still ramping rather than a long-lived operational toggle. - Recategorize `useFabricInterop` as operational, since it is a long-lived compatibility toggle rather than a rollout toward becoming the default. - Recategorize `preparedTextCacheSize` and `viewCullingOutsetRatio` as operational tuning values (dropping their now-unused `dateAdded`), matching `virtualViewPrerenderRatio`. Changelog: [Internal] Differential Revision: D112803274
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112803274. |
|
This pull request has been merged in b8e45a5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Corrects categorization metadata in the feature flags config. These are metadata-only changes: flag default values and runtime behavior are unchanged, and no generated files are affected (the codegen does not consume the
purposeordateAddedfields).dateAddedvalues to theYYYY-MM-DDconvention (enableAccessibilityOrder,useSharedAnimatedBackend,useTraitHiddenOnAndroid).enableDoubleMeasurementFixAndroidas an experimentation flag (adding itsdateAdded), since it gates a one-off fix that is still ramping rather than a long-lived operational toggle.useFabricInteropas operational, since it is a long-lived compatibility toggle rather than a rollout toward becoming the default.preparedTextCacheSizeandviewCullingOutsetRatioas operational tuning values (dropping their now-unuseddateAdded), matchingvirtualViewPrerenderRatio.Changelog:
[Internal]
Differential Revision: D112803274