Skip to content

Relocate CLI plugin server modules (#57654)#57654

Open
huntie wants to merge 2 commits into
react:mainfrom
huntie:export-D113412985
Open

Relocate CLI plugin server modules (#57654)#57654
huntie wants to merge 2 commits into
react:mainfrom
huntie:export-D113412985

Conversation

@huntie

@huntie huntie commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary:

Reorganise these modules under a src/dev-server/ directory (out of src/(commands|utils)/, more clearly identifying this unit of the codebase.

No public API change: the package still exports startCommand unchanged.

Renames inside this directory:

  • middleware.jsloadCommunityMiddleware.js
  • runServer.jsrunDevServer.js

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D113412985

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2026
@meta-codesync

meta-codesync Bot commented Jul 23, 2026

Copy link
Copy Markdown

@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113412985.

huntie added a commit to huntie/react-native that referenced this pull request Jul 23, 2026
Summary:
Pull Request resolved: react#57654

Reorganise these modules under a `src/dev-server/` directory (out of `src/(commands|utils)/`, more clearly identifying this unit of the codebase.

No public API change: the package still exports `startCommand` unchanged.

Renames inside this directory:

- `middleware.js` → `loadCommunityMiddleware.js`
- `runServer.js` → `runDevServer.js`

Changelog: [Internal]

Differential Revision: D113412985
@meta-codesync meta-codesync Bot changed the title Relocate CLI plugin server modules under dev-server dir Relocate CLI plugin server modules (#57654) Jul 23, 2026
@huntie
huntie force-pushed the export-D113412985 branch from cf7a8d7 to 4dfaa39 Compare July 23, 2026 16:46
huntie added a commit to huntie/react-native that referenced this pull request Jul 23, 2026
Summary:
Pull Request resolved: react#57654

Reorganise these modules under a `src/dev-server/` directory (out of `src/(commands|utils)/`, more clearly identifying this unit of the codebase.

No public API change: the package still exports `startCommand` unchanged.

Renames inside this directory:

- `middleware.js` → `loadCommunityMiddleware.js`
- `runServer.js` → `runDevServer.js`

Changelog: [Internal]

Differential Revision: D113412985
@huntie
huntie force-pushed the export-D113412985 branch from 4dfaa39 to 0ad2337 Compare July 23, 2026 17:11

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

huntie added 2 commits July 24, 2026 07:22
Summary:
Migrate the `codegen` and `spm` command implementations out of `react-native.config.js` and into the `react-native/community-cli-plugin` package, alongside the existing `bundleCommand` and `startCommand`.

This continues moving command definitions into the plugin so `react-native.config.js` becomes a thin routing layer, as the file's own comment already calls for.

**Changes**

- Add `src/commands/spm/index.js` and `src/commands/codegen/index.js`, each defining and default-exporting its command (unchanged `name`, `description`, and `options`) plus an exported args type — mirroring the `bundle`/`start` command structure.
- Export `spmCommand` and `codegenCommand` from `src/index.flow.js`.
- Drop the inline `spmCommand` and `codegenCommand` definitions from `react-native.config.js`.

Changelog: [Internal]

Differential Revision: D113412987
Summary:
Pull Request resolved: react#57654

Reorganise these modules under a `src/dev-server/` directory (out of `src/(commands|utils)/`, more clearly identifying this unit of the codebase.

No public API change: the package still exports `startCommand` unchanged.

Renames inside this directory:

- `middleware.js` → `loadCommunityMiddleware.js`
- `runServer.js` → `runDevServer.js`

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D113412985
@huntie
huntie force-pushed the export-D113412985 branch from 0ad2337 to c3455b2 Compare July 24, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants