Fix use-after-move of ContextContainer in PointerEventsProcessorTest - #57812
Open
javache wants to merge 1 commit into
Open
Fix use-after-move of ContextContainer in PointerEventsProcessorTest#57812javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: The whole `PointerEventsProcessorTest` suite has been aborting in its fixture constructor since the `modernize-use-designated-initializers` codemod moved the `ContextContainer` into `ComponentDescriptorParameters`. The `shared_ptr` is read twice more afterwards — once to construct the `UIManager` and once to construct the `ShadowTree` — so the move left both with a null container and the second read tripped the libstdc++ null-deref assert. Stop moving out of a `shared_ptr` that is still needed by later statements. Changelog: [Internal] Differential Revision: D114730311
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114730311. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The whole
PointerEventsProcessorTestsuite has been aborting in its fixture constructor since themodernize-use-designated-initializerscodemod moved theContextContainerintoComponentDescriptorParameters. Theshared_ptris read twice more afterwards — once to construct theUIManagerand once to construct theShadowTree— so the move left both with a null container and the second read tripped the libstdc++ null-deref assert.Stop moving out of a
shared_ptrthat is still needed by later statements.Changelog: [Internal]
Differential Revision: D114730311