Fix a couple of long-standing bugs in job board validation logic #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a heccin big bug on first merge unforunately. It was too complex, too difficult to understand, too easy to introduce weirdness. I tested this pretty comprehensively, testing message send in channel/thread/private thread, as well as editing messages in all those contexts.
vcarl
added a commit
that referenced
this pull request
Jan 9, 2025
Squashed commit of the following:
commit 02b2538186209b5fd91d9b7fe074c618065027cf
Author: Carl Vitullo <carl.vitullo@gmail.com>
Date: Thu Jan 9 18:44:08 2025 -0500
Revert "Add an API for active job posts (#427)"
This reverts commit f055545.
commit db62b36759d3baa125c3c925074514e06fd7638d
Author: Carl Vitullo <carl.vitullo@gmail.com>
Date: Thu Jan 9 18:44:05 2025 -0500
Revert "Revert "Fix a couple of long-standing bugs in job board validation logic (#429)""
This reverts commit 04d56fa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[for hire] im a developerThis is a rehash of #428 because of some showstopper bugs