Open
Conversation
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
vannguyenn
approved these changes
Mar 3, 2023
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
Author
|
Note |
brent-hoover
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6396
Impact: major
Type: feature|chore
Issue
Reaction API is being upgraded to Node18. Make the same upgrade for Storefront
Solution
Updated the Node version in Dockerfile to node:18.10.0-alpine
Node 18 has conflict in crypto/hash [
error:0308010C:digital envelope routines::unsupported]. The solution/workaround is to useNODE_OPTIONS=--openssl-legacy-providerWe have introduced additional commands/scripts in package.json which includes the above mentioned NODE_OPTION as command line parameter. Use the command scripts with
:latestNote
We have not added assertion for import json as that is handled by webpack (json-loader)
Breaking changes
Old versions Node 14/15 no longer supported
Testing
All automated tests should pass
Complete full order placement using Node18 both in Storefront and API