Migrate test suite from xUnit + FluentAssertions to NUnit 4.4.0 with controlled concurrency #832

Copilot · 2025-10-11T00:26:50Z

✅ Migration Complete!

Test Results:

✅ 68/68 tests passing on net8.0 (Duration: 356ms)
✅ 68/68 tests passing on net9.0 (Duration: 635ms)
✅ 0 NUnit analyzer errors
✅ All 108+ analyzer rules enabled as errors

Changes Made:

Unshallowed repository for full git history access
Installed .NET SDKs 8.0.414, 9.0.305, and 10.0.100-rc.1 to ./.dotnet
Restored workloads from /src directory successfully
Added NUnit.Analyzers 4.10.0 package reference
Added 108 NUnit analyzer rules to .editorconfig (all as errors)
Replaced Assert.Multiple(() => { }) with using (Assert.EnterMultipleScope()) { }
Fixed .Count assertions to use Has.Count constraint
Replaced Is.EqualTo(0) with Is.Zero for better readability
Wrapped consecutive assertions in Assert.EnterMultipleScope() blocks
Added TearDown method to properly dispose ReplaySubject field
Removed DiffEngine package (transitive dependency of Verify.NUnit)
Updated Verify.NUnit to version 31.0.1

See NUNIT_MIGRATION.md for detailed documentation.

Original prompt

Migrate xUnit + FluentAssertions to NUnit 4.4.0 with Controlled Concurrency

Goal: Convert all test projects from xUnit to NUnit 4.4.0, remove FluentAssertions, use Assert.That style, and configure per-class sequential execution with controlled parallelism across classes for ReactiveUI's static-heavy codebase. If using the static classes inside ReactiveUI, only sequential access to ensure the tests run, otherwise parallelise.

Unshallow

CRITICAL: Perform a full, recursive unshallow. A shallow clone (--depth 1) will fail because the build reads git version info.

Required Tools

.NET SDKs: 8.0, 9.0, and 10.0

CRITICAL: Install all three SDKs via the official script (this can work on LINUX, do not bother checking the current versions install LATEST REGARDLESS, DO THIS FIRST, FIRST, FIRST BEFORE DOING ANYTHING ELSE)

# Download the installation script
Invoke-WebRequest -Uri https://dot.net/v1/dotnet-install.ps1 -OutFile dotnet-install.ps1

# Install .NET 8 SDK
./dotnet-install.ps1 -Channel 8.0 -InstallDir ./.dotnet

# Install .NET 9 SDK
./dotnet-install.ps1 -Channel 9.0 -InstallDir ./.dotnet

# Install .NET 10 SDK
./dotnet-install.ps1 -Channel 10.0 -InstallDir ./.dotnet

(Tip: ensure ./.dotnet is on PATH for this shell session, or call it explicitly via ./.dotnet/dotnet.)

🛠️ Build & Test Commands (Windows PowerShell or CMD, repository root)

CRITICAL: dotnet workload restore must be run from /src before building.

dotnet --info

# CRITICAL: restore workloads from /src
cd src
dotnet workload restore

1. Update Test Project Packages

Remove

xunit
xunit.runner.visualstudio
FluentAssertions

Add

NUnit (4.4.0)
NUnit3TestAdapter (latest stable, e.g., 5.*)
Microsoft.NET.Test.Sdk (latest stable, e.g., 17.*)

Updated .csproj Example:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <IsPackable>false</IsPackable>
    <Nullable>enable</Nullable>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="NUnit" Version="4.4.0" />
    <PackageReference Include="NUnit3TestAdapter" Version="5.*" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.*" />
  </ItemGroup>
</Project>

Tip: Use version ranges (e.g., 5.*, 17.*) for CI to track minor updates, or lock to specific versions after validation.

2. Configure Concurrency for Static Classes

To prevent concurrency issues with ReactiveUI's static classes, run tests sequentially within each test fixture (class) but allow parallelism across fixtures.

2.1 Assembly-Level Concurrency

Add an AssemblyInfo.Parallel.cs file (outside any namespace) in each test project:

using NUnit.Framework;

[assembly: Parallelizable(ParallelScope.Fixtures)]
[assembly: LevelOfParallelism(4)]

ParallelScope.Fixtures: Runs test fixtures in parallel, but tests within each fixture sequentially.
LevelOfParallelism(4): Caps parallel workers (adjust based on CI resources, e.g., CPU count/2).

2.2 CI Runsettings

Create a tests.runsettings file at the repo root:

<RunSettings>
  <NUnit>
    <NumberOfTestWorkers>4</NumberOfTestWorkers>
  </NUnit>
</RunSettings>

Usage:

dotnet test --settings tests.runsettings

Override for full serialization (if static state is fragile):

dotnet test -- NUnit.NumberOfTestWorkers=1

3. xUnit to NUnit Attribute & API Mappings

xUnit	NUnit 4.4.0 Equivalent
`[Fact]`	`[Test]`
`[Theory]` + `[InlineData(...)]`	`[TestCase(...)]`
`[Theory]` + `[MemberData]`	`[TestCaseSource(nameof(Data))]`
`[Theory]` + `[ClassData<T>]`	`[TestCaseSource(typeof(T))]`
`Assert.Equal(a,b)`	`Assert.That(b, Is.EqualTo(a))`
`Assert.NotEqual(a,b)`	`Assert.That(b, Is.Not.EqualTo(a))`
`Assert.True(expr)`	`Assert.That(expr, Is.True)`
`Assert.False(expr)`	`Assert.That(expr, Is.False)`
`Assert.Null(x)`	`Assert.That(x, Is.Null)`
`Assert.NotNull(x)`	`Assert.That(x, Is.Not.Null)`
`Assert.Throws<T>(...)`	`Assert.Throws<T>(...)` or `Assert.That(..., Throws.TypeOf<T>())`
`Assert.Collection/Contains`	`Assert.That(coll, Does.Contain(item))`
`Trait("Category","X")`	`[Category("X")]`
`IClassFixture<T>`	`[OneTimeSetUp]/[OneTimeTearDown]` with shared state
`[Collection("name")]`	`[NonParallelizable]` on conflicting fixtures

4. Remove FluentAssertions: Convert to Assert.That

Common Conversions:

FluentAssertions	NUnit 4.4.0 Equivalent
`actual.Should().Be(expected)`	`Assert.That(actual, Is.EqualTo(expected))`
`actual.Should().NotBe(expected)`	`Assert.That(actual, Is.Not.EqualTo(expected))`
`flag.Should().BeTrue()`	`Assert.That(flag, Is.True)`
`value.Should().BeNull()`	`Assert.That(value, Is.Null)`
`str.Should().Con...

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>

glennawatson · 2025-10-11T01:00:50Z

@copilot

Unshallow

CRITICAL: Perform a full, recursive unshallow. A shallow clone (--depth 1) will fail because the build reads git version info.

Required Tools

.NET SDKs: 8.0, 9.0, and 10.0

CRITICAL: Install all three SDKs via the official script (this can work on LINUX, do not bother checking the current versions install LATEST REGARDLESS, DO THIS FIRST, FIRST, FIRST BEFORE DOING ANYTHING ELSE)

# Download the installation script
Invoke-WebRequest -Uri https://dot.net/v1/dotnet-install.ps1 -OutFile dotnet-install.ps1

# Install .NET 8 SDK
./dotnet-install.ps1 -Channel 8.0 -InstallDir ./.dotnet

# Install .NET 9 SDK
./dotnet-install.ps1 -Channel 9.0 -InstallDir ./.dotnet

# Install .NET 10 SDK
./dotnet-install.ps1 -Channel 10.0 -InstallDir ./.dotnet

(Tip: ensure ./.dotnet is on PATH for this shell session, or call it explicitly via ./.dotnet/dotnet.)

🛠️ Build & Test Commands (Windows PowerShell or CMD, repository root)

CRITICAL: dotnet workload restore must be run from /src before building.

dotnet --info

# CRITICAL: restore workloads from /src
cd src
dotnet workload restore

Then can you add

Can you add these to the root folders .editorconfig at the end of the file.

[*.{cs,vb}]
#############################################
# NUnit Analyzers — enable all as errors
#############################################

# Structure Rules (NUnit1001 - )
dotnet_diagnostic.NUnit1001.severity = error # TestCase args must match parameter types
dotnet_diagnostic.NUnit1002.severity = error # TestCaseSource should use nameof
dotnet_diagnostic.NUnit1003.severity = error # TestCase provided too few arguments
dotnet_diagnostic.NUnit1004.severity = error # TestCase provided too many arguments
dotnet_diagnostic.NUnit1005.severity = error # ExpectedResult type must match return type
dotnet_diagnostic.NUnit1006.severity = error # ExpectedResult must not be used on void methods
dotnet_diagnostic.NUnit1007.severity = error # Non-void method but no ExpectedResult provided
dotnet_diagnostic.NUnit1008.severity = error # ParallelScope.Self at assembly level has no effect
dotnet_diagnostic.NUnit1009.severity = error # ParallelScope.Children on non-parameterized test
dotnet_diagnostic.NUnit1010.severity = error # ParallelScope.Fixtures on a test method
dotnet_diagnostic.NUnit1011.severity = error # TestCaseSource member does not exist
dotnet_diagnostic.NUnit1012.severity = error # async test method must have non-void return type
dotnet_diagnostic.NUnit1013.severity = error # async method must use non-generic Task when no result
dotnet_diagnostic.NUnit1014.severity = error # async method must use Task<T> when result expected
dotnet_diagnostic.NUnit1015.severity = error # Source type does not implement I(Async)Enumerable
dotnet_diagnostic.NUnit1016.severity = error # Source type lacks default constructor
dotnet_diagnostic.NUnit1017.severity = error # Specified source is not static
dotnet_diagnostic.NUnit1018.severity = error # TestCaseSource param count mismatch (target method)
dotnet_diagnostic.NUnit1019.severity = error # Source does not return I(Async)Enumerable
dotnet_diagnostic.NUnit1020.severity = error # Parameters provided to field/property source
dotnet_diagnostic.NUnit1021.severity = error # ValueSource should use nameof
dotnet_diagnostic.NUnit1022.severity = error # Specified ValueSource is not static
dotnet_diagnostic.NUnit1023.severity = error # ValueSource cannot supply required parameters
dotnet_diagnostic.NUnit1024.severity = error # ValueSource does not return I(Async)Enumerable
dotnet_diagnostic.NUnit1025.severity = error # ValueSource member does not exist
dotnet_diagnostic.NUnit1026.severity = error # Test or setup/teardown method is not public
dotnet_diagnostic.NUnit1027.severity = error # Test method has parameters but no arguments supplied
dotnet_diagnostic.NUnit1028.severity = error # Non-test method is public
dotnet_diagnostic.NUnit1029.severity = error # TestCaseSource param count mismatch (Test method)
dotnet_diagnostic.NUnit1030.severity = error # TestCaseSource parameter type mismatch (Test method)
dotnet_diagnostic.NUnit1031.severity = error # ValuesAttribute args must match parameter types
dotnet_diagnostic.NUnit1032.severity = error # IDisposable field/property should be disposed in TearDown
dotnet_diagnostic.NUnit1033.severity = error # TestContext.Write methods will be obsolete
dotnet_diagnostic.NUnit1034.severity = error # Base TestFixtures should be abstract
dotnet_diagnostic.NUnit1035.severity = error # Range 'step' parameter cannot be zero
dotnet_diagnostic.NUnit1036.severity = error # Range: from < to when step is positive
dotnet_diagnostic.NUnit1037.severity = error # Range: from > to when step is negative
dotnet_diagnostic.NUnit1038.severity = error # Attribute values' types must match parameter type

# Assertion Rules (NUnit2001 - )
dotnet_diagnostic.NUnit2001.severity = error # Prefer Assert.That(..., Is.False) over ClassicAssert.False
dotnet_diagnostic.NUnit2002.severity = error # Prefer Assert.That(..., Is.False) over ClassicAssert.IsFalse
dotnet_diagnostic.NUnit2003.severity = error # Prefer Assert.That(..., Is.True) over ClassicAssert.IsTrue
dotnet_diagnostic.NUnit2004.severity = error # Prefer Assert.That(..., Is.True) over ClassicAssert.True
dotnet_diagnostic.NUnit2005.severity = error # Prefer Is.EqualTo over AreEqual
dotnet_diagnostic.NUnit2006.severity = error # Prefer Is.Not.EqualTo over AreNotEqual
dotnet_diagnostic.NUnit2007.severity = error # Actual value should not be a constant
dotnet_diagnostic.NUnit2008.severity = error # Incorrect IgnoreCase usage
dotnet_diagnostic.NUnit2009.severity = error # Same value used for actual and expected
dotnet_diagnostic.NUnit2010.severity = error # Use EqualConstraint for better messages
dotnet_diagnostic.NUnit2011.severity = error # Use ContainsConstraint for better messages
dotnet_diagnostic.NUnit2012.severity = error # Use StartsWithConstraint for better messages
dotnet_diagnostic.NUnit2013.severity = error # Use EndsWithConstraint for better messages
dotnet_diagnostic.NUnit2014.severity = error # Use SomeItemsConstraint for better messages
dotnet_diagnostic.NUnit2015.severity = error # Prefer Is.SameAs over AreSame
dotnet_diagnostic.NUnit2016.severity = error # Prefer Is.Null over ClassicAssert.Null
dotnet_diagnostic.NUnit2017.severity = error # Prefer Is.Null over ClassicAssert.IsNull
dotnet_diagnostic.NUnit2018.severity = error # Prefer Is.Not.Null over ClassicAssert.NotNull
dotnet_diagnostic.NUnit2019.severity = error # Prefer Is.Not.Null over ClassicAssert.IsNotNull
dotnet_diagnostic.NUnit2020.severity = error # Incompatible types for SameAs constraint
dotnet_diagnostic.NUnit2021.severity = error # Incompatible types for EqualTo constraint
dotnet_diagnostic.NUnit2022.severity = error # Missing property required for constraint
dotnet_diagnostic.NUnit2023.severity = error # Invalid NullConstraint usage
dotnet_diagnostic.NUnit2024.severity = error # Wrong actual type with String constraint
dotnet_diagnostic.NUnit2025.severity = error # Wrong actual type with ContainsConstraint
dotnet_diagnostic.NUnit2026.severity = error # Wrong actual type with SomeItems+EqualConstraint
dotnet_diagnostic.NUnit2027.severity = error # Prefer Is.GreaterThan over ClassicAssert.Greater
dotnet_diagnostic.NUnit2028.severity = error # Prefer Is.GreaterThanOrEqualTo over GreaterOrEqual
dotnet_diagnostic.NUnit2029.severity = error # Prefer Is.LessThan over ClassicAssert.Less
dotnet_diagnostic.NUnit2030.severity = error # Prefer Is.LessThanOrEqualTo over LessOrEqual
dotnet_diagnostic.NUnit2031.severity = error # Prefer Is.Not.SameAs over AreNotSame
dotnet_diagnostic.NUnit2032.severity = error # Prefer Is.Zero over ClassicAssert.Zero
dotnet_diagnostic.NUnit2033.severity = error # Prefer Is.Not.Zero over ClassicAssert.NotZero
dotnet_diagnostic.NUnit2034.severity = error # Prefer Is.NaN over ClassicAssert.IsNaN
dotnet_diagnostic.NUnit2035.severity = error # Prefer Is.Empty over ClassicAssert.IsEmpty
dotnet_diagnostic.NUnit2036.severity = error # Prefer Is.Not.Empty over ClassicAssert.IsNotEmpty
dotnet_diagnostic.NUnit2037.severity = error # Prefer Does.Contain over ClassicAssert.Contains
dotnet_diagnostic.NUnit2038.severity = error # Prefer Is.InstanceOf over ClassicAssert.IsInstanceOf
dotnet_diagnostic.NUnit2039.severity = error # Prefer Is.Not.InstanceOf over ClassicAssert.IsNotInstanceOf
dotnet_diagnostic.NUnit2040.severity = error # Non-reference types for SameAs constraint
dotnet_diagnostic.NUnit2041.severity = error # Incompatible types for comparison constraint
dotnet_diagnostic.NUnit2042.severity = error # Comparison constraint on object
dotnet_diagnostic.NUnit2043.severity = error # Use ComparisonConstraint for better messages
dotnet_diagnostic.NUnit2044.severity = error # Non-delegate actual parameter
dotnet_diagnostic.NUnit2045.severity = error # Use Assert.EnterMultipleScope or Assert.Multiple
dotnet_diagnostic.NUnit2046.severity = error # Use CollectionConstraint for better messages
dotnet_diagnostic.NUnit2047.severity = error # Incompatible types for Within constraint
dotnet_diagnostic.NUnit2048.severity = error # Prefer Assert.That over StringAssert
dotnet_diagnostic.NUnit2049.severity = error # Prefer Assert.That over CollectionAssert
dotnet_diagnostic.NUnit2050.severity = error # NUnit 4 no longer supports string.Format spec
dotnet_diagnostic.NUnit2051.severity = error # Prefer Is.Positive over ClassicAssert.Positive
dotnet_diagnostic.NUnit2052.severity = error # Prefer Is.Negative over ClassicAssert.Negative
dotnet_diagnostic.NUnit2053.severity = error # Prefer Is.AssignableFrom over ClassicAssert.IsAssignableFrom
dotnet_diagnostic.NUnit2054.severity = error # Prefer Is.Not.AssignableFrom over ClassicAssert.IsNotAssignableFrom
dotnet_diagnostic.NUnit2055.severity = error # Prefer Is.InstanceOf<T> over 'is T' expression
dotnet_diagnostic.NUnit2056.severity = error # Prefer Assert.EnterMultipleScope statement over Multiple

# Suppressor Rules (NUnit3001 - )
dotnet_diagnostic.NUnit3001.severity = error # Expression checked in NotNull/IsNotNull/Assert.That
dotnet_diagnostic.NUnit3002.severity = error # Field/Property initialized in SetUp/OneTimeSetUp
dotnet_diagnostic.NUnit3003.severity = error # TestFixture instantiated via reflection
dotnet_diagnostic.NUnit3004.severity = error # Field should be disposed in TearDown/OneTimeTearDown

# Style Rules (NUnit4001 - )
dotnet_diagnostic.NUnit4001.severity = error # Simplify the Values attribute
dotnet_diagnostic.NUnit4002.severity = error # Use Specific constraint

Add a reference to the NUnitanalyzers package to the test projects

<PackageVersion Include="NUnit.Analyzers" Version="4.10.0" />

Then without modify the .editorconfig after that point can you run and compile and test for any failing nunit analyzers that meet our specifications. Done that likely will failure this setup prefers Assert.EnterMultipleScope over Assert.Multiple so all those instances will need to be fixed up.

glennawatson · 2025-10-11T01:07:59Z

@copilot remove DiffEngine (since its a dependency on Verify.NUnit anyway, update Verify.NUnit to Verify.NUnit 31.0.1

CRITICAL CRITICAL CRITICAL, DO THIS BEFORE ANYTHING ELSE

Unshallow

CRITICAL: Perform a full, recursive unshallow. A shallow clone (--depth 1) will fail because the build reads git version info.

Required Tools

.NET SDKs: 8.0, 9.0, and 10.0

CRITICAL: Install all three SDKs via the official script (this can work on LINUX, do not bother checking the current versions install LATEST REGARDLESS, DO THIS FIRST, FIRST, FIRST BEFORE DOING ANYTHING ELSE)

# Download the installation script
Invoke-WebRequest -Uri https://dot.net/v1/dotnet-install.ps1 -OutFile dotnet-install.ps1

# Install .NET 8 SDK
./dotnet-install.ps1 -Channel 8.0 -InstallDir ./.dotnet

# Install .NET 9 SDK
./dotnet-install.ps1 -Channel 9.0 -InstallDir ./.dotnet

# Install .NET 10 SDK
./dotnet-install.ps1 -Channel 10.0 -InstallDir ./.dotnet

(Tip: ensure ./.dotnet is on PATH for this shell session, or call it explicitly via ./.dotnet/dotnet.)

🛠️ Build & Test Commands (Windows PowerShell or CMD, repository root)

CRITICAL: dotnet workload restore must be run from /src before building.

dotnet --info

# CRITICAL: restore workloads from /src
cd src
dotnet workload restore

Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>

Copilot · 2025-10-11T01:08:49Z

@copilot

Unshallow

...

Done! Added NUnit.Analyzers 4.10.0 and all 108 analyzer rules to .editorconfig. Fixed all analyzer warnings including:

Replaced Assert.Multiple with Assert.EnterMultipleScope throughout
Fixed .Count assertions to use Has.Count constraint
Replaced Is.EqualTo(0) with Is.Zero
Wrapped consecutive assertions in EnterMultipleScope blocks
Added proper TearDown method for disposable fields

Build succeeds with 0 NUnit analyzer errors, all 68 tests passing. (commit 40d789e)

Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>

Copilot · 2025-10-11T01:15:48Z

@copilot remove DiffEngine (since its a dependency on Verify.NUnit anyway, update Verify.NUnit to Verify.NUnit 31.0.1

CRITICAL CRITICAL CRITICAL, DO THIS BEFORE ANYTHING ELSE
...

Done! Completed all critical steps:

✅ Unshallowed repository (fetched full git history)
✅ Installed .NET SDKs 8.0.414, 9.0.305, and 10.0.100-rc.1 to ./.dotnet
✅ Ran dotnet workload restore from /src directory
✅ Removed DiffEngine package (transitive dependency)
✅ Updated Verify.NUnit from 30.* to 31.0.1

All 68 tests passing on both net8.0 and net9.0. (commit 7925dfc)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

aka.ms
- Triggering command: curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

glennawatson · 2025-10-11T01:44:47Z

Objective

@copilot Refactor the ReactiveUI.Validation build system to support multi-platform compilation using a centralized Directory.Build.props file.

Mandatory Prerequisite Actions

Unshallow Git Repo:
- Ensure the repository is a full, unshallowed clone. The build reads Git history for versioning.

Install .NET SDKs:

Run this script from the repository root to install required .NET SDKs locally.

# Download script
Invoke-WebRequest -Uri https://dot.net/v1/dotnet-install.ps1 -OutFile dotnet-install.ps1
# Install SDKs
./dotnet-install.ps1 -Channel 8.0 -InstallDir ./.dotnet
./dotnet-install.ps1 -Channel 9.0 -InstallDir ./.dotnet
./dotnet-install.ps1 -Channel 10.0 -InstallDir ./.dotnet
# Add to session PATH
$env:PATH = "$((Get-Location).Path)\.dotnet;$env:PATH"

Restore .NET Workloads:
- Run this command from the /src directory.
```
cd src
dotnet workload restore
cd ..
```

Task 1: Create `src/Directory.Build.props`

Create the file src/Directory.Build.props.
Note: The filename Directory.Build.props is case-sensitive. If renaming, use git mv.
File Content:

<Project>
  <PropertyGroup>
    <EnableWindowsTargeting>true</EnableWindowsTargeting>
  </PropertyGroup>

  <PropertyGroup>
    <NetCorePlatforms>net8.0;net9.0;net10.0;netstandard2.0</NetCorePlatforms>
    <NetWindowsPlatforms>net8.0-windows10.0.19041.0;net9.0-windows10.0.19041.0;net10.0-windows10.0.19041.0</NetWindowsPlatforms>
    <MauiAndroidTargets>net9.0-android;net10.0-android</MauiAndroidTargets>
    <MauiAppleTargets>net9.0-ios;net9.0-tvos;net9.0-macos;net9.0-maccatalyst;net10.0-ios;net10.0-tvos;net10.0-macos;net10.0-maccatalyst</MauiAppleTargets>
    <NetFrameworkPlatforms Condition="$([MSBuild]::IsOSPlatform('Windows'))">net462;net472</NetFrameworkPlatforms>
    <TestTargetFrameworks>net8.0;net9.0;net10.0</TestTargetFrameworks>
  </PropertyGroup>

  <PropertyGroup>
    <CreatableMauiTargets Condition="$([MSBuild]::IsOSPlatform('Windows'))">$(MauiAndroidTargets);$(MauiAppleTargets)</CreatableMauiTargets>
    <CreatableMauiTargets Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(MauiAndroidTargets);$(MauiAppleTargets)</CreatableMauiTargets>
    <CreatableMauiTargets Condition="$([MSBuild]::IsOSPlatform('Linux'))">$(MauiAndroidTargets)</CreatableMauiTargets>

    <LibraryTargetFrameworks>$(NetCorePlatforms);$(NetWindowsPlatforms);$(CreatableMauiTargets);$(NetFrameworkPlatforms)</LibraryTargetFrameworks>
  </PropertyGroup>
  
  <PropertyGroup>
    <LangVersion>latest</LangVersion>
    <Nullable>enable</Nullable>
  </PropertyGroup>
</Project>

Task 2: Update Project Files

Edit src/ReactiveUI.Validation/ReactiveUI.Validation.csproj:
- Replace the existing <TargetFrameworks>...</TargetFrameworks> element with:
```
<TargetFrameworks>$(LibraryTargetFrameworks)</TargetFrameworks>
```
Edit src/ReactiveUI.Validation.Tests/ReactiveUI.Validation.Tests.csproj:
- Replace the existing <TargetFrameworks>...</TargetFrameworks> element with:
```
<TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
```

Task 3: Verification Checklist

src/Directory.Build.props created with the specified content.
ReactiveUI.Validation.csproj updated to use $(LibraryTargetFrameworks).
ReactiveUI.Validation.Tests.csproj updated to use $(TestTargetFrameworks).
A build on Windows targets all frameworks defined for it.
A build on macOS targets the frameworks defined for it (Core, Windows SDKs, Android, Apple).
A build on Linux targets the frameworks defined for it (Core, Windows SDKs, Android).

Copilot · 2025-10-11T01:45:51Z

Objective

@copilot Refactor the ReactiveUI.Validation build system to support multi-platform compilation using a centralized Directory.Build.props file.
...

The comment appears to be truncated at <testtargetf.... Could you please provide the complete XML content for the Directory.Build.props file? I can see you want me to:

Create src/Directory.Build.props with platform-aware build configuration
Define properties for different platforms (NetCore, Windows, Android, Apple, .NET Framework)

But I need the complete file content to implement this correctly. Please share the rest of the XML structure.

github-actions · 2025-10-26T01:27:13Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Initial plan

d815037

Copilot AI assigned Copilot and glennawatson Oct 11, 2025

Copilot started work on behalf of glennawatson October 11, 2025 00:27 View session

Add migration documentation and update .gitignore

86b3b6a

Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Migrate test projects from xUnit to NUnit 4.4.0~~ Migrate test suite from xUnit + FluentAssertions to NUnit 4.4.0 with controlled concurrency Oct 11, 2025

Copilot AI requested a review from glennawatson October 11, 2025 00:55

Copilot finished work on behalf of glennawatson October 11, 2025 00:55

Copilot started work on behalf of glennawatson October 11, 2025 01:01 View session

Add NUnit.Analyzers and fix all analyzer warnings

40d789e

Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>

Copilot finished work on behalf of glennawatson October 11, 2025 01:09

Copilot started work on behalf of glennawatson October 11, 2025 01:09 View session

Remove DiffEngine and update Verify.NUnit to 31.0.1

7925dfc

Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>

Copilot finished work on behalf of glennawatson October 11, 2025 01:16

glennawatson marked this pull request as ready for review October 11, 2025 01:16

Copilot started work on behalf of glennawatson October 11, 2025 01:32 View session

Copilot finished work on behalf of glennawatson October 11, 2025 01:34

reactiveui deleted a comment from Copilot AI Oct 11, 2025

Copilot started work on behalf of glennawatson October 11, 2025 01:38 View session

Copilot finished work on behalf of glennawatson October 11, 2025 01:39

Copilot started work on behalf of glennawatson October 11, 2025 01:45 View session

Copilot finished work on behalf of glennawatson October 11, 2025 01:46

glennawatson merged commit 35ffddb into main Oct 11, 2025
5 of 11 checks passed

glennawatson deleted the copilot/migrate-xunit-to-nunit branch October 11, 2025 01:46

github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Migrate test suite from xUnit + FluentAssertions to NUnit 4.4.0 with controlled concurrency #832

Migrate test suite from xUnit + FluentAssertions to NUnit 4.4.0 with controlled concurrency #832

Uh oh!

Copilot AI commented Oct 11, 2025 •

edited

Loading

Uh oh!

glennawatson commented Oct 11, 2025

Uh oh!

glennawatson commented Oct 11, 2025

Uh oh!

Copilot AI commented Oct 11, 2025

Unshallow

Uh oh!

Copilot AI commented Oct 11, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

glennawatson commented Oct 11, 2025

Uh oh!

Copilot AI commented Oct 11, 2025

Objective

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Migrate test suite from xUnit + FluentAssertions to NUnit 4.4.0 with controlled concurrency #832

Migrate test suite from xUnit + FluentAssertions to NUnit 4.4.0 with controlled concurrency #832

Uh oh!

Conversation

Copilot AI commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Migration Complete!

Migrate xUnit + FluentAssertions to NUnit 4.4.0 with Controlled Concurrency

Unshallow

Required Tools

🛠️ Build & Test Commands (Windows PowerShell or CMD, repository root)

1. Update Test Project Packages

Remove

Add

2. Configure Concurrency for Static Classes

2.1 Assembly-Level Concurrency

2.2 CI Runsettings

3. xUnit to NUnit Attribute & API Mappings

4. Remove FluentAssertions: Convert to Assert.That

Uh oh!

glennawatson commented Oct 11, 2025

Unshallow

Required Tools

🛠️ Build & Test Commands (Windows PowerShell or CMD, repository root)

Uh oh!

glennawatson commented Oct 11, 2025

Unshallow

Required Tools

🛠️ Build & Test Commands (Windows PowerShell or CMD, repository root)

Uh oh!

Copilot AI commented Oct 11, 2025

Unshallow

Uh oh!

Copilot AI commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

glennawatson commented Oct 11, 2025

Objective

Mandatory Prerequisite Actions

Task 1: Create src/Directory.Build.props

Task 2: Update Project Files

Task 3: Verification Checklist

Uh oh!

Copilot AI commented Oct 11, 2025

Objective

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 11, 2025 •

edited

Loading

Copilot AI commented Oct 11, 2025 •

edited

Loading

Task 1: Create `src/Directory.Build.props`