Skip to content

chore: enable the expanded StyleSharp analyzer rule set and resolve all violations#4385

Merged
glennawatson merged 35 commits into
mainfrom
feature/analyzer-cleanup-sst313
Jun 24, 2026
Merged

chore: enable the expanded StyleSharp analyzer rule set and resolve all violations#4385
glennawatson merged 35 commits into
mainfrom
feature/analyzer-cleanup-sst313

Observe PayCommand on UI thread; init WinForms

b316c35
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 24, 2026 in 1s

93.07% (+3.37%) compared to 30dcf2f

View this Pull Request on Codecov

93.07% (+3.37%) compared to 30dcf2f

Details

Codecov Report

❌ Patch coverage is 98.02131% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.07%. Comparing base (30dcf2f) to head (b316c35).

Files with missing lines Patch % Lines
...ctiveUI.Wpf.Shared/Binding/ValidationBindingWpf.cs 72.72% 2 Missing and 4 partials ⚠️
...c/ReactiveUI.Core/Expression/ExpressionRewriter.cs 80.00% 0 Missing and 1 partial ⚠️
src/ReactiveUI.Shared/Activation/ViewForMixins.cs 88.88% 0 Missing and 1 partial ⚠️
...erty/Internal/PropertyBindingExpressionCompiler.cs 0.00% 0 Missing and 1 partial ⚠️
...operty/PropertyBinderImplementation.Conversions.cs 90.90% 0 Missing and 1 partial ⚠️
src/ReactiveUI.Shared/Routing/MessageBus.cs 66.66% 1 Missing ⚠️
...activeUI.Winforms/CreatesWinformsCommandBinding.cs 92.85% 0 Missing and 1 partial ⚠️
...veUI.Wpf.Shared/WpfPropertyBinderImplementation.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4385      +/-   ##
==========================================
+ Coverage   89.69%   93.07%   +3.37%     
==========================================
  Files         341      343       +2     
  Lines       14948    14924      -24     
  Branches     1502     1570      +68     
==========================================
+ Hits        13408    13890     +482     
+ Misses       1208      770     -438     
+ Partials      332      264      -68     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.