Skip to content

Conversation

@JayPanoz
Copy link
Collaborator

@JayPanoz JayPanoz commented Dec 17, 2024

Please check if the PR fulfills these requirements:

(Add x between brackets to check.)

  • I’ve read contributing guidelines
  • I’m making this pull request against the develop branch
  • I’ve updated from the develop branch before proposing this pull request
  • I’ve tested the changes for bug fixes and/or features
  • I’ve documented new code

What kind of change does this PR introduce? (Bug fix, feature, docs update, other)

This is a bug fix to make font-size user setting work on iPadOS ’desktop-class’ experience.

Closes #155

What is the current behaviour? (You can also link to an open issue here)

zoom won’t work on iPadOS in desktop mode (as opposed to “request mobile version”) if we don’t set text-size-adjust: none.

What is the new behaviour?

This PR changes the value from 100% to none.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

It shouldn’t based on testing that has been done, but corner cases obviously exist and are meant to be discovered.

@JayPanoz JayPanoz merged commit b7616fc into develop Dec 17, 2024
1 check passed
@JayPanoz JayPanoz deleted the fontSize-fix branch December 17, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--USER-fontSize not working on Safari iOS

2 participants