Skip to content

Conversation

@JayPanoz
Copy link
Collaborator

@JayPanoz JayPanoz commented Jun 19, 2025

This PR aims to make Readium CSS more consistent following implementers’ feedback.

Primarily, this:

  • consolidates custom colors for theming into a single user submodule;
  • removes the fontOverride flag following the removal of advancedSettings;
  • removes day mode and migrate its declarations in base
  • creates opt-out flag for overflow

@JayPanoz
Copy link
Collaborator Author

This is now complete.

Overflow complications will be handled in another version, TBD.

@JayPanoz JayPanoz marked this pull request as ready for review June 20, 2025 10:54
@JayPanoz JayPanoz merged commit 1f3f48a into develop Jun 20, 2025
1 check passed
@JayPanoz JayPanoz deleted the beta-14 branch June 20, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theming requires a full-fledged reorg of modules Should the overflow: clip fix be an opt-in? fontOverride user setting

2 participants