Skip to content

Fix vertical alignment of filter checkboxes in search modal #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix vertical alignment of filter checkboxes in search modal #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
952fabf
Initial plan
Copilot Dec 4, 2025
7396838
Initial plan for fixing filter checkbox alignment
Copilot Dec 4, 2025
b92a6aa
Fix vertical alignment of filter checkboxes
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dist/readthedocs-addons.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/readthedocs-addons.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion src/search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,12 +337,14 @@ div.hit-block .hit-block-heading-container svg {
}

:host > div .filters li {
display: inline-block;
display: inline-flex;
Copy link
Contributor

@agjohnson agjohnson Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching this to flex shouldn't be required. Flex will introduce other spacing issues, like vertical spacing when elements wrap on mobile viewports.

vertical-align: middle on the input is the same effect.

Image

However, normally checkboxes are baseline aligned, not middle aligned. It looks normal to me on Firefox -- the checkbox is aligned with the text baseline:

image

Copy link
Member

@ericholscher ericholscher Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agjohnson I'm not sure how to take this feedback? The screenshots above show the issue -- what is the change that fixes it?

Copy link
Member

@humitos humitos Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's the fix here either, but I can reproduce the issue that Eric is trying to fix in Firefox as well. I don't know if this is the correct way or not, but this PR fixes the issue locally to me.

Copy link
Contributor

@agjohnson agjohnson Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to take this feedback?

I'm saying this shouldn't switch to flex, all that is needed is an alignment change. Using flex has other alignment side effects.

The screenshots above show the issue

The first screenshot does not, it shows the same alignment as this PR. This is using vertical-align: middle on the input.

align-items: center;
margin: 0 0 0 15px;
}

:host > div .filters li label {
padding: 3px;
cursor: pointer;
}

:host > div .filters label {
Expand Down