Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 17 additions & 30 deletions src/GuessControl.js
Original file line number Diff line number Diff line change
@@ -1,45 +1,32 @@
import React, { Component } from "react";
import React, { useState } from "react";
import Button from "./Button";

class GuessControl extends Component {
constructor(props) {
super(props);

this.state = {
currentGuess: "",
};

/**
* These lines are required to make the methods/functions declared on this
* class have the correct `this` object when they run.
*/
this.handleInputChange = this.handleInputChange.bind(this);
this.onSubmitGuess = this.onSubmitGuess.bind(this);
}

handleInputChange(event) {
this.setState({ currentGuess: event.target.value });
function GuessControl() {
Copy link
Copy Markdown
Collaborator Author

@riousenkai riousenkai Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game isn't working. What's missing here? Check line 47 of NumberGuessingGame.js


const [ currentGuess, setCurrentGuess ] = useState('')

const handleInputChange = (event) => {
setCurrentGuess( Number(event.target.value) );
}

onSubmitGuess() {
// Since the values from an HTML input are strings by default,
// convert to a number for the returned guess value
this.props.onGuess(Number(this.state.currentGuess));
this.setState({ currentGuess: "" });
const onSubmitGuess = () => {
setCurrentGuess('')
}

render() {
return (
return (
<>
<div>
<input
type="number"
value={this.state.currentGuess}
onChange={this.handleInputChange}
value={currentGuess}
onChange={handleInputChange}
/>
<Button onClick={this.onSubmitGuess}>Submit Guess</Button>
<Button onClick={onSubmitGuess}>Submit Guess</Button>
</div>
);
}
</>
)
}


export default GuessControl;
64 changes: 25 additions & 39 deletions src/NumberGuessingGame.js
Original file line number Diff line number Diff line change
@@ -1,77 +1,63 @@
import React, { Component } from "react";
import React, { useState } from "react";
import GuessControl from "./GuessControl";
import GuessMessage from "./GuessMessage";
import GameOver from "./GameOver";

/**
*
* Returns a random integer number from 1-100 inclusive
*/
function getRandomNumber() {
return Math.floor(Math.random() * 100) + 1;
}

const MAX_ATTEMPTS = 5;
function NumberGuessingGame() {

class NumberGuessingGame extends Component {
constructor(props) {
super(props);

this.state = {
const [ numberData, setNumberData ] = useState({
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should place each of these values in separate useStates. No need to force them in an object.

numberToGuess: getRandomNumber(),
numberOfGuesses: 0,
latestGuess: null,
};
})

/**
* These lines are required to make the methods/functions declared on this
* class have the correct `this` object when they run.
*/
this.handleGuess = this.handleGuess.bind(this);
this.handleReset = this.handleReset.bind(this);
function getRandomNumber() {
return Math.floor(Math.random() * 100) + 1;
}

handleGuess(guess) {
this.setState({
const MAX_ATTEMPTS = 5;

const handleGuess = (guess) => {
setNumberData({
latestGuess: guess,
numberOfGuesses: this.state.numberOfGuesses + 1,
numberOfGuesses: numberData.numberOfGuesses + 1,
});
}

handleReset() {
this.setState({
const handleReset = () => {
setNumberData({
numberToGuess: getRandomNumber(),
numberOfGuesses: 0,
latestGuess: null,
});
}

render() {
const isCorrectGuess = this.state.latestGuess === this.state.numberToGuess;
const isCorrectGuess = numberData.latestGuess === numberData.numberToGuess;

const isGameOver =
isCorrectGuess || this.state.numberOfGuesses === MAX_ATTEMPTS;
const isGameOver = isCorrectGuess || numberData.numberOfGuesses === MAX_ATTEMPTS;

return (
return (
<>
<div>
<h2>I'm thinking of a number from 1 to 100.</h2>
<h2>
Can you guess the number I am thinking of in {MAX_ATTEMPTS} tries?
</h2>
<GuessControl onGuess={this.handleGuess} />
<GuessControl onGuess={handleGuess} />
{isGameOver && (
<GameOver hasWon={isCorrectGuess} onReset={this.handleReset} />
<GameOver hasWon={isCorrectGuess} onReset={handleReset} />
)}
{!isGameOver && (
<GuessMessage
guess={this.state.latestGuess}
numberToGuess={this.state.numberToGuess}
numberOfGuesses={this.state.numberOfGuesses}
guess={numberData.latestGuess}
numberToGuess={numberData.numberToGuess}
numberOfGuesses={numberData.numberOfGuesses}
/>
)}
</div>
);
}
}
</>
)
}

export default NumberGuessingGame;