Skip to content

Changed upper version limit of System.Diagnostics.DiagnosticSource - #28

Closed
Freddie-H wants to merge 3 commits into
rebus-org:masterfrom
Freddie-H:net10_support
Closed

Changed upper version limit of System.Diagnostics.DiagnosticSource#28
Freddie-H wants to merge 3 commits into
rebus-org:masterfrom
Freddie-H:net10_support

Conversation

@Freddie-H

@Freddie-H Freddie-H commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

#27 Add support for .net10 by changing the upper version limit for System.Diagnostics.DiagnosticSource

@CLAassistant

CLAassistant commented Nov 17, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@zlepper
zlepper self-requested a review November 17, 2025 13:08
@Freddie-H Freddie-H closed this Nov 17, 2025
@Freddie-H Freddie-H reopened this Nov 17, 2025
@zlepper

zlepper commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

I have written to the guy who is in charge of Rebus. He can investigate why it doesn't handle the cla, and he also have access to release a new build :)

@mookid8000

Copy link
Copy Markdown
Member

When the CLA thing doesn't seem to work, it's because the email address used in the git commits has not been registered on GitHub, which makes it impossible for the CLA tool to correlate the commits with the GitHub user account.

It's clearly visible here, since the commits are made by "mdridder-reconi" and not "Freddie-H":
{A029AEF1-E453-46BA-9219-3F3199F6ED03}

The solution is simply for @Freddie-H to go to his GitHub profile settings and add the email address used as an additional email.

@Freddie-H Freddie-H closed this Nov 17, 2025
@Freddie-H

Freddie-H commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Sorry, having multiple github accounts screwed me a bit.
I've made a new PR (#29) and closed this one, the check is succesful in the other PR now

@Freddie-H
Freddie-H deleted the net10_support branch November 17, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants