Safeguard against broken headers causing message processing to hang when handling incoming message - #32
Merged
Merged
Conversation
Member
|
I agree very much with the approach. Logging and metrics collection should never, ever, be the reason why anything crashes. I've pushed a new version as Rebus.OpenTelemetry 1.4.0 to NuGet.org just now 🙂 Thanks for contributing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm probably being a bit overzealous with the try-catching here, however because we are so early in the Rebus pipeline (Maybe we should actually be hooking in later), if we fumble and throw an exception, then it seems Rebus just hangs.
One of our QA people found that if you manage to inject some "Zalgo" text: https://zalgo.org/ (Github apparently strips those characters completely in text messages). Then newtonsoft might throw an exception when parsing the value again. That was then causing our entire system to not process messages :)