Closed
Conversation
The lipSync model (latentsync) often outputs slightly longer video than the input audio, causing ~0.2s of frozen frames at the end of each beat. This is especially noticeable when multiple lipSync beats are concatenated. Add trimVideoToBuffer() utility and use it in lipSyncReplicateAgent to trim the output video to exactly match the audio duration. Fixes #1274 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Skip tpad=stop_mode=clone for lipSync beats (prevents frozen last frame) - Add adjustVideoDuration to stretch lipSync output to match audio - Add getBufferDuration utility for probing buffer duration Known issues: - setpts stretch breaks lip sync (need different approach) - Still frame at end of video not fully resolved Closes #1274 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1274 — lipSync beats show frozen last frame at transitions.
tpad=stop_mode=clonefor lipSync beats → eliminates frozen frame at beat boundariesadjustVideoDuration(setpts stretch) breaks lip sync — needs different approachChanges
src/actions/movie.ts—getVideoPart()acceptsisLipSyncparam, skips tpad for lipSync beatssrc/utils/ffmpeg_utils.ts— AddedgetBufferDuration()andadjustVideoDuration()utilitiessrc/agents/lipsync_replicate_agent.ts— CallsadjustVideoDuration()after lipSync generationNext steps
adjustVideoDuration— setpts stretching desynchronizes lip movements from audioTest plan
🤖 Generated with Claude Code