[DowngradePhp80] Add DowngradeSubstrFalsyRector#339
Merged
Merged
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
samsonasik
marked this pull request as draft
October 13, 2025 14:50
Member
Author
|
Tested in existing vendor under this repo, it seems there are too many cast that should not be needed. Drafting for now. |
samsonasik
marked this pull request as ready for review
October 20, 2025 10:07
Member
Author
|
@TomasVotruba I already applied as many use case skip as possible so it make less noise on downgrade, let's merge to have faster feedback to test :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#9413