[PHPUnit 13] Fix class in expectExceptionMessage() rename to TestCase - #735
Merged
Merged
Conversation
MethodCallRename used PHPUnit\Framework\TestClass, which does not exist, so the rename never applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PHPUNIT_130set renamedexpectExceptionMessage()onPHPUnit\Framework\TestClass— a class that does not exist. The rename never applied.Fixed to
PHPUnit\Framework\TestCase, so the set now handles the phpunit#6560 soft deprecation (PHPUnit 13.2):final class SomeTest extends TestCase { public function test(): void { - $this->expectExceptionMessage('some message'); + $this->expectExceptionMessageIsOrContains('some message'); } }