Deprecate WillReturnCallbackFallbackToThrowRector - #740
Merged
TomasVotruba merged 1 commit intoJul 31, 2026
Conversation
The case is very rare and hardly automatable, and the rule is not part of any set - it sat commented out in the code-quality set. Better handle it in a custom way, or keep the code untouched.
TomasVotruba
deleted the
deprecate-will-return-callback-fallback-to-throw
branch
July 31, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WillReturnCallbackFallbackToThrowRectoris not part of any set. It sat commented out inphpunit-code-quality.phpbehind an "enable once better tested" note, so it only ran when registered by hand.The pattern it targets is very rare and hardly automatable - it only fires on a
willReturnCallback()closure that uses$matcher, branches on the invocation count, and ends on anifwith no explicit fallback return:$this->someServiceMock->expects($matcher) ->method('run') ->willReturnCallback(function () use ($matcher) { if ($matcher->numberOfInvocations() === 1) { return 1; } + + throw new \PHPUnit\Framework\Exception(sprintf('Method should not be called for the %dth time', $matcher->numberOfInvocations())); });Whether an extra call should throw, return a default, or is simply not worth guarding is a per-test decision. Better handled in a custom way, or left untouched.
Standard deprecation shape: implements
DeprecatedInterface,refactor()throws, tests removed, commented-out set entry dropped.MatcherInvocationCountMethodCallNodeFactorystays -WillReturnCallbackFactorystill uses it.