Add MockObjectArgCreateStubToCreateMockRector - #741
Merged
Conversation
… to createMock() when passed to MockObject param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stub/mock rules move
createMock()→createStub()when a mock has no expectations. But a variable can be passed to a local helper method that requiresMockObjectand callsexpects()on it — there a stub is a type error.This rule fixes those spots back:
public function testNotificationOfUnpublishToAuthor(): void { $event = new Event(); - $user = $this->createStub(User::class); + $user = $this->createMock(User::class); $this->prepareCommonMocks($event, $user); } /** * @param MockObject&User $user */ private function prepareCommonMocks(Event $event, MockObject $user): void { $user->expects($this->once()) ->method('getId') ->willReturn(1); }Real-world case: mautic/mautic NotificationHelperTest
Only triggers when the variable is passed as an argument to a method/static call whose parameter type is
MockObject— native type, docblock intersection, positional or named argument. A stub used only formethod()/willReturn()is left alone.Registered in
phpunit110.phpandphpunit-mock-to-stub.phpsets. No ping-pong withExpressionCreateMockToCreateStubRector, which already skips variables passed toMockObjectparams.