Bond annotation to attribute rules to phpunit/phpunit >=10.0 - #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit attributes exist since PHPUnit 10.0. Until now these rules converted annotations to attributes regardless of the PHPUnit version installed in the analysed project, so a PHPUnit 9 project ended up with attributes it cannot use.
Each of the 7 annotation to attribute rules now declares the constraint:
Covered rules:
TicketAnnotationToAttributeRectorTestWithAnnotationToAttributeRectorDataProviderAnnotationToAttributeRectorCoversAnnotationWithValueToAttributeRectorRequiresAnnotationWithValueToAttributeRectorDependsAnnotationWithValueToAttributeRectorAnnotationWithValueToAttributeRectorOn a project with
phpunit/phpunit: ^9.6, the rules are now skipped:Note:
ComposerPackageConstraintFiltertreats an unresolvable version as "not satisfied", so these rules are also skipped whenphpunit/phpunitis missing from the analysed project'sinstalled.json.For the generic
AnnotationToAttributeRectorpairs inannotations-to-attributes.phpno change is needed - the set is pulled in byphpunit100.php, and version-specific pairs added later tophpunit110.phpstack on top, as repeatedruleWithConfiguration()calls for the same rule class are merged.PHP version bond
Attributes are a PHP 8.0 feature, so a rule that adds an attribute must also declare
MinPhpVersionInterface. The 7 rules above already did. Three more rules add attributes and were missing it:AllowMockObjectsForDataProviderRectorAllowMockObjectsWhereParentClassRectorAllowMockObjectsWithoutExpectationsAttributeRectorOn a PHP 7.4 project they no longer produce a parse-error-causing
#[AllowMockObjectsWithoutExpectations].