Bond stub and mock rules to phpunit/phpunit >=11.0 - #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub and mock rules were only reachable through
PHPUnitSetList::PHPUNIT_MOCK_TO_STUB, with nothing tying them to a PHPUnit version. They now declare the constraint themselves and are registered in the composer-based set, sowithComposerBased(phpunit: true)picks them up on any project with PHPUnit 11 or newer.Rules bound to
>=11.0:CreateStubOverCreateMockArgRectorCreateStubInCoalesceArgRectorExpressionCreateMockToCreateStubRectorPropertyCreateMockToCreateStubRectorMockObjectVarToStubRectorAddIntersectionVarToMockObjectPropertyRectorAddStubIntersectionVarToStubPropertyRectorBareCreateMockAssignToDirectUseRectorMockObjectArgCreateStubToCreateMockRectoralready declared>=11.0and was already in the set.And registered in
composer-based.php:phpunit-mock-to-stub.phpis left as is - the rules now self-gate wherever they are registered, so a PHPUnit 10 project including that set no longer gets stub conversions it cannot use.Based on #749, which restores
rector/rector-srctodev-main; without itcomposer installfails onmain.