Add ExpectsParamToMockObjectRector for private test method params

config/sets/composer-based.php

@@ -16,6 +16,7 @@
 use Rector\PHPUnit\CodeQuality\Rector\Class_\AddStubIntersectionVarToStubPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector;
 use Rector\PHPUnit\PHPUnit110\Rector\CallLike\AssertContainsOnlyMethodCallRector;
+use Rector\PHPUnit\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector;
 use Rector\PHPUnit\PHPUnit110\Rector\ClassMethod\MockObjectArgCreateStubToCreateMockRector;
 use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubInCoalesceArgRector;
 use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
@@ -55,6 +56,7 @@
 
         // mocks back over stubs, where a mock object is required
         MockObjectArgCreateStubToCreateMockRector::class,
+        ExpectsParamToMockObjectRector::class,
 
         // deprecated in PHPUnit 11.5
         AssertContainsOnlyMethodCallRector::class,

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/ExpectsParamToMockObjectRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class ExpectsParamToMockObjectRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/fixture.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class ExpectsOnParam extends TestCase
+{
+    private function prepareUserMock(SomeUser $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId')
+            ->willReturn(1);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class ExpectsOnParam extends TestCase
+{
+    private function prepareUserMock(\PHPUnit\Framework\MockObject\MockObject $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId')
+            ->willReturn(1);
+    }
+}
+
+?>

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/only_expects_param.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class OnlyExpectsParam extends TestCase
+{
+    private function prepareUserMock(SomeUser $user, SomeUser $anotherUser): void
+    {
+        $anotherUser->getId();
+
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class OnlyExpectsParam extends TestCase
+{
+    private function prepareUserMock(\PHPUnit\Framework\MockObject\MockObject $user, SomeUser $anotherUser): void
+    {
+        $anotherUser->getId();
+
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}
+
+?>

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/skip_docblock_param.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class SkipDocblockParam extends TestCase
+{
+    /**
+     * @param SomeUser $user
+     */
+    private function prepareUserMock(SomeUser $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/skip_intersection_param.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class SkipIntersectionParam extends TestCase
+{
+    private function prepareUserMock(SomeUser&MockObject $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/skip_mock_object_param.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipMockObjectParam extends TestCase
+{
+    private function prepareUserMock(MockObject $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/skip_no_expects.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class SkipNoExpects extends TestCase
+{
+    private function useUser(SomeUser $user): void
+    {
+        $user->getId();
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/skip_non_test_class.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class SkipNonTestClass
+{
+    private function prepareUserMock(SomeUser $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Fixture/skip_public_method.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source\SomeUser;
+
+final class SkipPublicMethod extends TestCase
+{
+    public function prepareUserMock(SomeUser $user): void
+    {
+        $user->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/Source/SomeUser.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector\Source;
+
+final class SomeUser
+{
+    public function getId(): int
+    {
+        return 1;
+    }
+}

rules-tests/PHPUnit110/Rector/ClassMethod/ExpectsParamToMockObjectRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\PHPUnit\PHPUnit110\Rector\ClassMethod\ExpectsParamToMockObjectRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(ExpectsParamToMockObjectRector::class);
+};