[CodeQuality] Add AddIntersectionParamToMockObjectParamRector

config/sets/composer-based.php

@@ -12,6 +12,7 @@
 use Rector\PHPUnit\AnnotationsToAttributes\Rector\ClassMethod\DataProviderAnnotationToAttributeRector;
 use Rector\PHPUnit\AnnotationsToAttributes\Rector\ClassMethod\DependsAnnotationWithValueToAttributeRector;
 use Rector\PHPUnit\AnnotationsToAttributes\Rector\ClassMethod\TestWithAnnotationToAttributeRector;
+use Rector\PHPUnit\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\AddIntersectionVarToMockObjectPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\AddStubIntersectionVarToStubPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector;
@@ -57,6 +58,7 @@
         // mocks back over stubs, where a mock object is required
         MockObjectArgCreateStubToCreateMockRector::class,
         ExpectsParamToMockObjectRector::class,
+        AddIntersectionParamToMockObjectParamRector::class,
 
         // deprecated in PHPUnit 11.5
         AssertContainsOnlyMethodCallRector::class,

config/sets/phpunit-mock-to-stub.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\PHPUnit\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\AddIntersectionVarToMockObjectPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\AddStubIntersectionVarToStubPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector;
@@ -27,5 +28,6 @@
 
         // mocks back over stubs, where mock object is required
         MockObjectArgCreateStubToCreateMockRector::class,
+        AddIntersectionParamToMockObjectParamRector::class,
     ]);
 };

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/AddIntersectionParamToMockObjectParamRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AddIntersectionParamToMockObjectParamRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/direct_create_mock_arg.php.inc

@@ -0,0 +1,48 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class DirectCreateMockArgTest extends TestCase
+{
+    public function test(): void
+    {
+        $this->prepareServiceMock($this->createMock(\stdClass::class));
+    }
+
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class DirectCreateMockArgTest extends TestCase
+{
+    public function test(): void
+    {
+        $this->prepareServiceMock($this->createMock(\stdClass::class));
+    }
+
+    /**
+     * @param \stdClass&\PHPUnit\Framework\MockObject\MockObject $someService
+     */
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/fixture.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SomeTest extends TestCase
+{
+    public function test(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SomeTest extends TestCase
+{
+    public function test(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    /**
+     * @param \stdClass&\PHPUnit\Framework\MockObject\MockObject $someService
+     */
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/second_param_only.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SecondParamOnlyTest extends TestCase
+{
+    public function test(): void
+    {
+        $builder = self::createMock(\stdClass::class);
+
+        $this->getEventListener(new \DateTime('now'), $builder);
+    }
+
+    private function getEventListener(\DateTime $dateTime, \PHPUnit\Framework\MockObject\MockObject $builder): void
+    {
+        $builder->expects($this->once())
+            ->method('add');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SecondParamOnlyTest extends TestCase
+{
+    public function test(): void
+    {
+        $builder = self::createMock(\stdClass::class);
+
+        $this->getEventListener(new \DateTime('now'), $builder);
+    }
+
+    /**
+     * @param \stdClass&\PHPUnit\Framework\MockObject\MockObject $builder
+     */
+    private function getEventListener(\DateTime $dateTime, \PHPUnit\Framework\MockObject\MockObject $builder): void
+    {
+        $builder->expects($this->once())
+            ->method('add');
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_create_stub.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipCreateStubTest extends TestCase
+{
+    public function test(): void
+    {
+        $someService = $this->createStub(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_different_mocked_classes.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipDifferentMockedClassesTest extends TestCase
+{
+    public function testFirst(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    public function testSecond(): void
+    {
+        $someService = $this->createMock(\DateTime::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_existing_param_doc.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipExistingParamDocTest extends TestCase
+{
+    public function test(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    /**
+     * @param MockObject $someService
+     */
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_no_call_site.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipNoCallSiteTest extends TestCase
+{
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_non_test_class.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+
+final class SkipNonTestClass
+{
+    public function run(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_public_method.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipPublicMethodTest extends TestCase
+{
+    public function test(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $this->prepareServiceMock($someService);
+    }
+
+    public function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/Fixture/skip_reassigned_variable.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector\Fixture;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipReassignedVariableTest extends TestCase
+{
+    public function test(): void
+    {
+        $someService = $this->createMock(\stdClass::class);
+        $someService = $this->createMock(\DateTime::class);
+
+        $this->prepareServiceMock($someService);
+    }
+
+    private function prepareServiceMock(MockObject $someService): void
+    {
+        $someService->expects($this->once())
+            ->method('getId');
+    }
+}

rules-tests/CodeQuality/Rector/Class_/AddIntersectionParamToMockObjectParamRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\PHPUnit\CodeQuality\Rector\Class_\AddIntersectionParamToMockObjectParamRector;
+
+return RectorConfig::configure()
+    ->withRules([AddIntersectionParamToMockObjectParamRector::class]);