Skip to content

[CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2 #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Oct 1, 2025
Merged

[CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2 #7391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ final class SimplifyRegexPatternRector extends AbstractRector
* @var array<string, string>
*/
private const COMPLEX_PATTERN_TO_SIMPLE = [

@TomasVotruba TomasVotruba Oct 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add note about the scoper issue? So we at least know "why" , since there is no test fixture to verify

@samsonasik samsonasik Oct 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@samsonasik samsonasik Oct 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixture is exists, see https://github.com/rectorphp/rector-src/pull/7390/files#diff-50a42149759f087eb3dce4cbe895b8f759b6e1b26013eb262d8a088c39706e03

It just issue with php-scoper.

I will look if it can simply be handled by double quote.

@samsonasik samsonasik Oct 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properly resolved with double quoted:

on dev-main rectorphp/rector@d61e2b7

Tested locally, working ok.

I will add the note comment.

@samsonasik samsonasik Oct 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created PR to add comment about it

'[0-9]' => '\\d',
'[a-zA-Z0-9_]' => '\\w',
'[A-Za-z0-9_]' => '\\w',
'[0-9a-zA-Z_]' => '\\w',
'[0-9A-Za-z_]' => '\\w',
'[\r\n\t\f\v ]' => '\\s',
'[0-9]' => '\\\d',
'[a-zA-Z0-9_]' => '\\\w',
'[A-Za-z0-9_]' => '\\\w',
'[0-9a-zA-Z_]' => '\\\w',
'[0-9A-Za-z_]' => '\\\w',
'[\r\n\t\f\v ]' => '\\\s',
];

public function __construct(
Expand Down