Remove no longer needed tweak AlwaysRememberedExpr on Printer per PHPStan 2.1.34 - #7770
Merged
Conversation
Member
Author
|
Tested as well on rector- packages:
with require-dev: "phpstan/phpstan": "2.1.x-dev",
"rector/rector-src": "dev-test-phpstan-21x",and seems working ok 👍 
|
TomasVotruba
marked this pull request as draft
January 13, 2026 14:09
Member
|
Note: waits on next PHPStan release, after 2.1.33 |
samsonasik
force-pushed
the
test-phpstan-21x
branch
from
January 19, 2026 20:05
7c8e5f5 to
e164dae
Compare
samsonasik
changed the title
samsonasik
marked this pull request as ready for review
January 19, 2026 20:05
Member
Author
|
@TomasVotruba PHPStan 2.1.34 just released phpstan/phpstan#13976 It seems there is error on https://github.com/rectorphp/rector-src/actions/runs/21150113451/job/60824192355?pr=7770 I will check on separate PR. |
samsonasik
marked this pull request as draft
January 19, 2026 21:09
Member
Author
|
wait for PR: to be merged first for fix compatible code. |
samsonasik
marked this pull request as ready for review
January 19, 2026 21:35
Member
Author
|
I will rebase |
samsonasik
force-pushed
the
test-phpstan-21x
branch
from
January 19, 2026 21:38
e164dae to
fed36b0
Compare
samsonasik
changed the title
Member
Author
|
Finally, All green 🎉 @TomasVotruba ready 👍 |
samsonasik
changed the title
Member
|
Thank you 👍 |
calebdw
added a commit
to calebdw/rector-src
that referenced
this pull request
Jan 20, 2026
… per PHPStan 2.1.34 (rectorphp#7770)" This reverts commit 38d1caf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current composer.json already require phpstan 2.1.34, so this tweak
AlwaysRememberedExprno longer needed.Per PHPStan PR: