[Scoper] Cleanup DateRangeError from exclusions on scoper.php - #7930
Merged
Conversation
since we use php 8.3 already on runner of scoped build. This exclusion `DateRangeError` that already available on php 8.3 should no longer needed.
Member
Author
|
@TomasVotruba let's give it a try 👍 |
Member
Author
|
It seems working ok 👍 rectorphp/rector@39640ba |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateRangeErrorexists since php 8.3since we use php 8.3 already on runner of scoped build. This exclusion
DateRangeErrorthat already available on php 8.3 should no longer needed.it was used to tweak build on php 8.2, and now we are building on top of php 8.3
ref build on top of php 8.3
rector-src/.github/workflows/build_scoped_rector.yaml
Line 41 in 61d95b8