[Php81] Skip array dim fetch args in NullToStrictStringFuncCallArgRector#8164
Merged
Conversation
TomasVotruba
force-pushed
the
remove-null-strict-string-from-level
branch
from
July 10, 2026 09:31
d4eb82d to
5b19bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullToStrictStringFuncCallArgRectornow skips array dim fetch args ($array['key']).Array dim fetch values are
mixed— thenullis not known, so casting to(string)may be wrong. Now explicitly skipped:public function run(array $data) { - return str_replace('a', 'b', (string) $data['key']); + return str_replace('a', 'b', $data['key']); }