Fix bug with composer-based command and Symfony configuration - #8280
Merged
Conversation
TomasVotruba
force-pushed
the
composer-based-symfony
branch
from
August 3, 2026 17:11
95b53e4 to
fe2a075
Compare
- add symfony: true to withComposerBased() - fix fatal error in "composer-based" command on lazily-initialized typed properties (PHPStan UnionType::$normalized) - skip ConsoleExecuteReturnIntRector, it adds a redundant (int) cast that RecastingRemovalRector removes again
TomasVotruba
force-pushed
the
composer-based-symfony
branch
from
August 3, 2026 17:17
85897d8 to
1d338ac
Compare
composer-based command and Symfony configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted in: #8246 (comment)
Adds
symfony: truetowithComposerBased()inrector.php, so rector-src is covered by the Symfony composer-bound rules.Fix: fatal error in
bin/rector composer-basedThe Symfony
composer-based.phpset builds aUnionTypevianewInstanceWithoutConstructor()and only setstypes, leaving$normalizeduninitialized. Rendering the configuration table then crashed:foreach ($reflectionObject->getProperties() as $reflectionProperty) { + // lazy-initialized property, e.g. PHPStan UnionType::$normalized + if (! $reflectionProperty->isInitialized($value)) { + continue; + } + $printedPropertyValues[] = $this->printConfigurationValue($reflectionProperty->getValue($value)); }