[Sets] Drop Symfony per-version set providers from the collector - #8292
Merged
Conversation
Symfony3SetProvider to Symfony8SetProvider only registered composer-triggered sets that the Symfony composer-based set already covers, rule for rule. rector-symfony empties them in rectorphp/rector-symfony#1010, so the collector can stop asking them for sets. SymfonySetProvider and TwigSetProvider stay, as they carry the composer-based sets.
TomasVotruba
force-pushed
the
remove-symfony-per-version-set-providers
branch
from
August 5, 2026 09:25
fb065b8 to
43e2aac
Compare
Member
Author
|
CI unrelated to sets, caused by PHPStan type change. |
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to rectorphp/rector-symfony#1010.
Symfony3SetProvider…Symfony8SetProviderregistered 208 per-versionComposerTriggeredSets. Every rule in them is already inconfig/sets/symfony/composer-based.php, where it carries its own package version constraint — verified rule by rule in that PR, 0 rules missing. rector-symfony removes those providers, so the collector stops asking them for sets.SymfonySetProvidergoes with them, in the same rector-symfony PR: the composer-based set is reachable throughSymfonySetList::COMPOSER_BASED, which is exactly whatwithComposerBased(symfony: true)adds, and the remaining Symfony sets through their ownSymfonySetListconstants.TwigSetProviderstays —SetGroup::TWIGis wired intowithComposerBased(), so its composer-based trigger is still resolved throughSetManager.Follow-up, not in this PR
rector-symfony#1010 also trims
TwigSetProviderto its single composer-based trigger. Once that is released and pulled in here,SetManagerTestneeds updating —testMatchComposerTriggered()asserts 8 Twig triggered sets, andprovideInstalledTwigData()expects the per-version Twig sets alongside the composer-based one.