Skip to content

[Sets] Update SetManagerTest to the single Twig composer-based set #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomasVotruba wants to merge 1 commit into from
Closed

[Sets] Update SetManagerTest to the single Twig composer-based set #8294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions tests/Set/SetManager/SetManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function testMatchComposerTriggered(): void
$setManager = $this->createSetManagerWithProjectDirectory(getcwd());

$twigComposerTriggeredSet = $setManager->matchComposerTriggered(SetGroup::TWIG);
$this->assertCount(8, $twigComposerTriggeredSet);
$this->assertCount(1, $twigComposerTriggeredSet);
}

/**
Expand All @@ -42,21 +42,13 @@ public function testByVersion(string $projectDirectory, array $expectedSets): vo
*/
public static function provideInstalledTwigData(): Iterator
{
// here we cannot used features coming up in 2.4, as we only have 2.0
yield [
__DIR__ . '/Fixture/project-twig-20',
[realpath(TwigSetList::COMPOSER_BASED), realpath(TwigSetList::TWIG_20)],
];
// the composer-based set covers every Twig version, as each rule inside it is bound
// to the exact twig/twig version it needs
yield [__DIR__ . '/Fixture/project-twig-20', [realpath(TwigSetList::COMPOSER_BASED)]];

yield [
__DIR__ . '/Fixture/project-twig-24',
[realpath(TwigSetList::COMPOSER_BASED), realpath(TwigSetList::TWIG_20), realpath(TwigSetList::TWIG_24)],
];
yield [__DIR__ . '/Fixture/project-twig-24', [realpath(TwigSetList::COMPOSER_BASED)]];

yield [
__DIR__ . '/Fixture/project-twig-127',
[realpath(TwigSetList::COMPOSER_BASED), realpath(TwigSetList::TWIG_112), realpath(TwigSetList::TWIG_127)],
];
yield [__DIR__ . '/Fixture/project-twig-127', [realpath(TwigSetList::COMPOSER_BASED)]];
}

private function createSetManagerWithProjectDirectory(string $projectDirectory): SetManager
Expand Down
Loading