[DeadCode] Add RemoveRedundantTypeCheckRector

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/array_param_truthy_check.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class ArrayParamTruthyCheck
+{
+    public function buildWhereClauseFromArray($query, array $clauses, $expr = null): void
+    {
+        if ($clauses && is_array($clauses)) {
+            return;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class ArrayParamTruthyCheck
+{
+    public function buildWhereClauseFromArray($query, array $clauses, $expr = null): void
+    {
+        if ($clauses) {
+            return;
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/nullable_int_from_method_call.php.inc

@@ -0,0 +1,47 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class NullableIntFromMethodCall
+{
+    public function run(): void
+    {
+        $count = $this->resolveCount();
+        if ($count === null || ! is_int($count)) {
+            return;
+        }
+
+        echo $count;
+    }
+
+    private function resolveCount(): ?int
+    {
+        return 1;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class NullableIntFromMethodCall
+{
+    public function run(): void
+    {
+        $count = $this->resolveCount();
+        if ($count === null) {
+            return;
+        }
+
+        echo $count;
+    }
+
+    private function resolveCount(): ?int
+    {
+        return 1;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/nullable_string.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class NullableString
+{
+    public function run(?string $securityExpression): void
+    {
+        if (null === $securityExpression || ! is_string($securityExpression)) {
+            return;
+        }
+
+        echo $securityExpression;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class NullableString
+{
+    public function run(?string $securityExpression): void
+    {
+        if (null === $securityExpression) {
+            return;
+        }
+
+        echo $securityExpression;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/nullable_string_truthy_check.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class NullableStringTruthyCheck
+{
+    public function run(?string $value): void
+    {
+        if ($value && is_string($value)) {
+            echo $value;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class NullableStringTruthyCheck
+{
+    public function run(?string $value): void
+    {
+        if ($value) {
+            echo $value;
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/skip_another_variable.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class SkipAnotherVariable
+{
+    public function run(?string $value, mixed $anotherValue): void
+    {
+        if (null === $value || ! is_string($anotherValue)) {
+            return;
+        }
+
+        echo $value;
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/skip_docblock_array_param.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class SkipDocblockArrayParam
+{
+    /**
+     * @param mixed[] $clauses
+     */
+    public function run($clauses): void
+    {
+        if ($clauses && is_array($clauses)) {
+            return;
+        }
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/skip_docblock_nullable_param.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class SkipDocblockNullableParam
+{
+    /**
+     * @param ?string $value
+     */
+    public function run($value): void
+    {
+        if (null === $value || ! is_string($value)) {
+            return;
+        }
+
+        echo $value;
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/skip_truthy_check_on_union.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class SkipTruthyCheckOnUnion
+{
+    public function run(array|string $value): void
+    {
+        if ($value && is_array($value)) {
+            return;
+        }
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/skip_untyped_param.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class SkipUntypedParam
+{
+    public function run($value): void
+    {
+        if (null === $value || ! is_string($value)) {
+            return;
+        }
+
+        echo $value;
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/Fixture/skip_wider_union_type.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector\Fixture;
+
+final class SkipWiderUnionType
+{
+    public function run(string|int|null $value): void
+    {
+        if (null === $value || ! is_string($value)) {
+            return;
+        }
+
+        echo $value;
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/RemoveRedundantTypeCheckRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveRedundantTypeCheckRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DeadCode/Rector/BinaryOp/RemoveRedundantTypeCheckRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\BinaryOp\RemoveRedundantTypeCheckRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(RemoveRedundantTypeCheckRector::class);
+};