[DeadCode] Skip RemoveParentDelegatingConstructorRector on protected parent constructor - #8309
Merged
TomasVotruba merged 1 commit intoAug 6, 2026
Conversation
TomasVotruba
enabled auto-merge (squash)
August 6, 2026 14:11
…parent constructor
TomasVotruba
force-pushed
the
fix-remove-parent-delegating-constructor-protected-parent
branch
from
August 6, 2026 14:14
9e4c1a6 to
b25a22b
Compare
TomasVotruba
deleted the
fix-remove-parent-delegating-constructor-protected-parent
branch
August 6, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9842
The rule checked that the child constructor is public, but never checked the parent's visibility. Removing a public constructor that delegates to a
protectedparent one silently narrows visibility and breaks instantiation:Fatal error: Uncaught Error: Call to protected A::__construct() from global scopeBuggy behavior before this PR:
class A { protected function __construct($value) { } } class B extends A { - public function __construct($value) - { - parent::__construct($value); - } } new B('value'); // fatal error after the changeNow the rule bails out when the parent constructor is not public, so the code above is left untouched.