Skip to content

Define PHP 7.4 token constants for downgraded build #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jun 2, 2026
Merged

Define PHP 7.4 token constants for downgraded build #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions bin/swiss-knife.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,19 @@
}
}

// the released tool is downgraded to PHP 7.2, but the bundled nikic/php-parser
// references PHP 7.4 token constants directly - define them to avoid fatal errors
// (see https://github.com/easy-coding-standard/ecs/blob/main/bin/ecs.php for the same approach)
if (! defined('T_FN')) {
define('T_FN', 5025);
}
if (! defined('T_COALESCE_EQUAL')) {
define('T_COALESCE_EQUAL', 5030);
}
if (! defined('T_BAD_CHARACTER')) {
define('T_BAD_CHARACTER', 5035);
}
Comment on lines +33 to +41

@samsonasik samsonasik Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, this should be equal with php 8.+ values:

php > echo T_FN;
311
php > echo T_COALESCE_EQUAL;
367
php > echo T_BAD_CHARACTER;
409

@TomasVotruba TomasVotruba Jun 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really matter, as it's a placeholder value. If it's not existing token value.

5xxx are reserved


$containerFactory = new ContainerFactory();
$container = $containerFactory->create();

Expand Down
Loading