Fix #128: remove symfony/console dependency by adopting Entropy - #131
Merged
Conversation
Migrate CLI output from SymfonyStyle to OutputPrinter and ProgressBar, remove the direct symfony/console dependency, and bump entropy to ^0.4.0 to resolve dependency conflicts in Symfony 8 projects (fixes rectorphp#128).
Contributor
Author
|
@TomasVotruba Ready for review.
|
Member
|
Looks good💪 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128
Summary
Resolves the Composer dependency conflict reported in #128 by removing the direct
symfony/consolerequirement and adopting Entropy as the console layer.Projects using Symfony 8 (e.g.
symfony/yaml ^8.1) could not installrector/swiss-knifebecause the package requiredsymfony/console ^6.4.24, which conflicts with Symfony 8 components. This PR fixes that root cause instead of widening thesymfony/consoleconstraint (see maintainer feedback on #129).What changed
symfony/consolefromcomposer.jsonentropy/entropyto^0.4.0SymfonyStylewithEntropy\Console\Output\OutputPrinterin CLI commands andClassConstantFetchFinderProgressBarwithEntropy\Console\Output\ProgressBarwhere neededSymfonyStyleregistration fromContainerFactoryTest plan
composer validatevendor/bin/phpunitvendor/bin/phpstan analysevendor/bin/ecs checkvendor/bin/composer-dependency-analyserbin/swiss-knife --helpSymfony\Component\Consoleusage insrc,tests,bin,config