Skip to content

Don't merge - RHAIENG-4981: Turn on hermetic flag to true for RHDS#2408

Draft
ysok wants to merge 1 commit into
red-hat-data-services:mainfrom
ysok-red-hat-data-services:RHAIENG-4981-hermetic-true
Draft

Don't merge - RHAIENG-4981: Turn on hermetic flag to true for RHDS#2408
ysok wants to merge 1 commit into
red-hat-data-services:mainfrom
ysok-red-hat-data-services:RHAIENG-4981-hermetic-true

Conversation

@ysok

@ysok ysok commented Jun 25, 2026

Copy link
Copy Markdown

RHAIENG-4981: Turn on hermetic flag to true for RHDS

Description

RHAIENG-4981: Turn on hermetic flag to true for RHDS

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ff9968c9-64a3-4bd5-91b6-6c1e238ab018

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@ysok — This PR is from a fork.
The build-rhoai CI job was skipped because subscription
builds (RHEL, AIPCC) need secrets unavailable to forks.
ODH builds and code quality checks still ran.

Recommended: Push your branch to the main repo for full CI:

git remote add upstream https://github.com/red-hat-data-services/notebooks.git
git push upstream HEAD:ysok/your-branch-name

Then open a new PR from that branch.

No push access? A maintainer will cherry-pick and test your changes.

See CONTRIBUTING.md for details.

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/kfbuild all

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/build-konflux

@ysok ysok force-pushed the RHAIENG-4981-hermetic-true branch from 27fb80d to 8c80d23 Compare June 25, 2026 15:20
@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/build-konflux

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/kfbuild runtimes/pytorch/ubi9-python-3.12

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/build-runtime-pytorch-cuda

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/build-jupyter-datascience

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

/build-workbench-jupyter-minimal-cuda

@ysok

ysok commented Jun 25, 2026

Copy link
Copy Markdown
Author

All Konflux builds were success

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant