Update tests and dependencies#37
Merged
Merged
Conversation
Expand npm test to run all test suites under __tests__/ instead of only __tests__/redux/. This picks up 9 pre-existing test files that were never being executed. Exclude 6 legacy test files that import from a removed src/models/ module. Add new test files: - Redux reducers: ocs, ui, zone (complete reducer coverage) - Root utilities: kubelet, units, node, service - Lib utilities: kubelet, workload (areServicesSchedulable, isWorkloadSchedulable, getWorkloadFromDescriptors) Fix pre-existing workloads.spec.ts to not depend on hardcoded service IDs, which broke when test execution order changed. Coverage: 3 → 16 test suites, 23 → 156 tests, branches 69% → 83% Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Chris Blum <cblum@ibm.com>
Remove browserify, coffeescript, @types/fabric, and @types/jquery which are not referenced anywhere in the codebase. Removing browserify alone eliminates 4 critical vulnerabilities (elliptic, cipher-base, sha.js, pbkdf2) and several high-severity ones. Update minor/patch versions within current semver ranges: - lodash 4.17.21 → 4.18.1 (fixes prototype pollution) - express 4.18.2 → 4.22.1 (fixes XSS and open redirect) - body-parser 1.20.2 → 1.20.4 (fixes DoS) - js-yaml 4.1.0 → 4.1.1 (fixes prototype pollution) - jest 29.5.0 → 29.7.0 - html-webpack-plugin 5.5.0 → 5.6.7 - @emotion/react 11.10.4 → 11.14.0 - @emotion/styled 11.10.4 → 11.14.1 - classnames 2.3.1 → 2.5.1 - html2canvas 1.3.3 → 1.4.1 Vulnerabilities reduced from 86 to 69, critical from 5 to 0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Chris Blum <cblum@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mulbc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
Resolves #5 |
bipuladh
reviewed
Apr 23, 2026
| service/node_modules/ | ||
| *.log | ||
| coverage | ||
| CLAUDE.md |
Member
Author
There was a problem hiding this comment.
Didn't want to accidentally commit it in this PR
Collaborator
There was a problem hiding this comment.
Better to save it for Claude we might have to add some rules to it regarding generation of comments and everything. By default too many comments are generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests and update dependencies to bring down the vulnerability count