fix: check that slices belong to the permission checked article - #6617
Merged
Conversation
The writing slice operations derived the category permission from the article given in the request, while the operation itself acted on an independent slice reference from the same request. Nothing verified that the addressed slice actually belongs to that article, so combining an own article with a foreign slice id allowed editors to delete, (de)activate, move and - with a matching module/template constellation - overwrite slices in categories they have no permission for. The content page additionally did not check the clang permission at all, in contrast to all api functions, so slices could be added, edited and deleted in languages the user has no access to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writing slice operations checked the permission for the article given in the request, but acted on an independent slice reference from the same request. The content page also did not check the clang permission.
Details are intentionally brief here — the relevant parts are only mentioned in the commit message for now and will be described properly once released.