Consolidate shared test binaries in pytest_ofrak; make tests pass in source tree layout#699
Open
ANogin wants to merge 3 commits intoredballoonsecurity:masterfrom
Open
Consolidate shared test binaries in pytest_ofrak; make tests pass in source tree layout#699ANogin wants to merge 3 commits intoredballoonsecurity:masterfrom
pytest_ofrak; make tests pass in source tree layout#699ANogin wants to merge 3 commits intoredballoonsecurity:masterfrom
Conversation
whyitfor
requested changes
Feb 4, 2026
Contributor
whyitfor
left a comment
whyitfor
left a comment
There was a problem hiding this comment.
The correct way to fix this is to move this test file to pytest_ofrak, so both ofrak and this library can use it.
This will enable testing of pypi release (which we have not eyt made for pyghidra.
There should be patterns in other libraries that draw assets from that.
Move the test asset to pytest_ofrak so both ofrak_core and ofrak_pyghidra can reference it, enabling pypi release testing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move hello.x64.elf, fib, and fib_thumb binaries to pytest_ofrak/assets/ for shared use across disassembler packages. These identical binaries were previously duplicated across ofrak_angr, ofrak_ghidra, and ofrak_cached_disassembly test directories. Also fix gitignore pattern for Ghidra project directories. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ANogin
changed the title
pytest_ofrak; make tests pass in source tree layout
ANogin
pushed a commit
that referenced
this pull request
Feb 8, 2026
… tests pass in source tree layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Move shared test asset to pytest_ofrak for use by both ofrak_core and ofrak_pyghidra
(do we update changelog for something like that?)
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Move shared test assets to
pytest_ofrak/src/pytest_ofrak/assets/so multiple packages can reference them viapytest_ofrak.ASSETS_DIR:hello_world.ihex- shared byofrak_coreandofrak_pyghidrahello.x64.elf,fib,fib_thumb- shared byofrak_angr,ofrak_ghidra, andofrak_cached_disassembly(previously duplicated)Also fixes
.gitignorepattern for Ghidra project directories (**/assets/*_ghidra/).This approach:
Anyone you think should look at this, specifically?
@whyitfor