Adding: Timetable Command #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novanai
requested changes
Jan 6, 2026
Contributor
novanai
left a comment
novanai
left a comment
There was a problem hiding this comment.
Quite a few changes needed unfortunately sorry! I can handle the miru-based stuff as there is a specific (and somewhat complex) way for this to be done nicely.
src/extensions/timetable.py
Outdated
| ): | ||
| if resp.status == 200: | ||
| matching_fields = await resp.json() | ||
| except aiohttp.ClientError: |
Contributor
There was a problem hiding this comment.
Errors like this should be handled in a global or command-based error handler
+ Fixed to proper Plugin Name + Improved description for plugin + Changed multi-line comments to single-line + Improved error and status code handling for command (Prevents double sending of results) + Used global client session through DI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the Timetable command, which connects to the service at https://timetable.redbrick.dcu.ie/. This feature allows users to access information about all courses, modules, locations, clubs, and societies through the blockbot. It also provides users with a link to connect their calendar and an option to download the ICS file.
Closes #69