feat: Show ArgoCD App Projects in Resource List page #146
Conversation
Signed-off-by: Atif Ali <atali@redhat.com>
aali309
force-pushed
the
listAppProjects
branch
from
e068d6d to
d1818ef
Compare
| }, | ||
| }, | ||
| { | ||
| cell: t('Last Updated'), |
There was a problem hiding this comment.
I know some of the other lists do not have it, but could you put a Labels column here? See the Rollouts list for example
| } | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
Could you move this above Rollouts and add a separator? Something like this:
There was a problem hiding this comment.
{
"type": "console.navigation/separator",
"properties": {
"perspective": "admin",
"section": "gitops-navigation-section",
"id": "argocd-separator",
"insertAfter": "appproject",
}
},
console-extensions.json
Outdated
| "type": "console.navigation/resource-ns", | ||
| "properties": { | ||
| "id": "appproject", | ||
| "name": "App Projects", |
There was a problem hiding this comment.
Make it the pluralized kind, eg. "AppProjects" instead of "App Projects"
| ], | ||
| }, | ||
| { | ||
| filterGroupName: t('Source Repositories'), |
There was a problem hiding this comment.
Some of these filters appear very useful indeed. From what I understand, the filters act upon the information presented from one of the columns in the table. For example, in the applications list page, the filter is based on sync status or health status. So you filter the table to show only those apps that are healthy. Here, the source repositories and Destinations aren't shown in any column. I see the value though and can be convinced to keep these. Your thoughts?
There was a problem hiding this comment.
You are right, these filters don’t correspond to the visible columns, but they are valuable because users often want to filter projects by the repos and destinations. Also, AppProjects are configuration objects where source repos and destinations define security boundaries. Users often need to find projects based on their allowed repositories or deployment targets, even if those fields aren’t shown as columns. The filters help with security governance and operational discovery. I think yes, we should keep these filters.
| <div> | ||
| {showTitle == undefined && ( | ||
| <ListPageHeader | ||
| title={t('App Projects')} |
There was a problem hiding this comment.
I believe this has to be the pluralized kind, eg. AppProjects, to be consistent with the other k8s resources list pages.
Signed-off-by: Atif Ali <atali@redhat.com>
keithchong
left a comment
keithchong
left a comment
There was a problem hiding this comment.
@aali309 . Label column looks good. Just a few comments and I think it'll be good to go.
| { | ||
| id: 'gitops-action-edit-project', | ||
| disabled: !project?.metadata?.namespace || !project?.metadata?.name, | ||
| label: t('Edit App Project'), |
| bValue = b.metadata?.labels || {}; | ||
| break; | ||
| case 'last-updated': | ||
| aValue = getLastUpdateTimestamp(a); |
There was a problem hiding this comment.
The sort doesn't seem to work for me. I had two projects and they didn't sort properly. It sorted ascending, but didn't switch the order back on descending, on any of the following time formats:
Just now
9 minutes ago
Dec 8, 2025, 9:19 AM
Dec 8, 2025, 11:33 AM
I need to fix this in the Rollouts list too.
| @@ -0,0 +1,7 @@ | |||
| .project-list-page { | |||
| &__topology-link { | |||
There was a problem hiding this comment.
Will you be using this? The rollouts stuff will link to the topology.
There was a problem hiding this comment.
removed the unused topology-link SCSS
| hideFavoriteButton={false} | ||
| > | ||
| <ListPageCreate groupVersionKind={modelToRef(AppProjectModel)}> | ||
| {t('Create App Project')} |
…ink SCSS Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
keithchong
left a comment
keithchong
left a comment
There was a problem hiding this comment.
LGTM. Thanks @aali309 !
2 participants
Fixes: GITOPS-7364
Filter options