Skip to content

Revert "fix: sanitize host and username values before base64 encoding in secrets"#801

Merged
adrianriobo merged 1 commit into
redhat-developer:mainfrom
jangel97:fix-trailing-newline-in-secrets-v2
May 14, 2026
Merged

Revert "fix: sanitize host and username values before base64 encoding in secrets"#801
adrianriobo merged 1 commit into
redhat-developer:mainfrom
jangel97:fix-trailing-newline-in-secrets-v2

Conversation

@jangel97
Copy link
Copy Markdown
Contributor

Summary

  • Reverts fix: remove trailing newline from connection detail output files #799 — the tr -d '\n\r' was applied to all base64 -w0 lines including id_rsa, which strips internal newlines from PEM private keys and breaks SSH authentication (Load key "id_rsa": error in libcrypto)
  • Will follow up with a corrected fix that only trims single-line values (host, username, passwords) and leaves multi-line values (id_rsa, kubeconfig) untouched

Copy link
Copy Markdown
Collaborator

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianriobo adrianriobo merged commit 0e675cb into redhat-developer:main May 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants