Move to LSP4j 0.13.0#645
Merged
Merged
Conversation
Contributor
Author
|
This PR requires redhat-developer/vscode-quarkus#506 |
Collaborator
|
@rgrunber can you check this update won't break in Theia, pretty please? |
Collaborator
|
@angelozerr there are 5 failures in https://github.com/redhat-developer/quarkus-ls/pull/645/checks |
Contributor
Author
Ooops goot catch, it should be fixed. |
Fixes redhat-developer#644 Signed-off-by: azerr <azerr@redhat.com>
AlexXuChen
reviewed
Jun 8, 2022
Contributor
AlexXuChen
left a comment
AlexXuChen
left a comment
There was a problem hiding this comment.
InlayHint is still working properly:
One thing to note is that I needed to make updates to https://download.eclipse.org/jdtls/snapshots/repository/latest, similar to https://github.com/redhat-developer/quarkus-ls/pull/577/files#diff-ff34482d69102e42f3609f3b86315fdbafa8e9cf44fd676b3a1f7f1d8fb93ed2R41
Contributor
Author
|
Thanks @AlexXuChen for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to LSP4j 0.13.0
Fixes #644
Signed-off-by: azerr azerr@redhat.com