feat(export): export consistent yarn project#89
Open
gashcrumb wants to merge 1 commit intoredhat-developer:mainfrom
Open
feat(export): export consistent yarn project#89gashcrumb wants to merge 1 commit intoredhat-developer:mainfrom
gashcrumb wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
gashcrumb
force-pushed
the
RHIDP-12902
branch
3 times, most recently
from
fa07083 to
f0e5eeb
Compare
This change updates the CLI's frontend script to create a yarn.lock based on the exported plugin package in a similar fashion to backend plugins. This makes the exported plugin package for frontend plugins more consistent with backend plugins and allows another means for security scanners to inspect the plugin's dependencies. This change also moves functions that are shared between the backend and frontend commands into a shared utils file so it's more obvious which functions are common to each command. A new .yarnrc.yml is created in the exported plugin package to ensure consistency when running "yarn install" during plugin export. Also workspace resolutions are taken from the adjacent package.json file when the yarn lockfile is discovered and applied to the derived exported package. This change also adds some documents that summarize the plugin export process. Finally this change adds a prepare script so that it's possible to run this command with changes from a pull request without having to perform a release for testing purposes. Assisted-By: Cursor Desktop rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
Member
Author
|
This PR can easily be tested locally via npx now, just have to be patient as it builds on the fly, but you can run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the CLI's frontend script to create a yarn.lock based on the exported plugin package in a similar fashion to backend plugins. This makes the exported plugin package for frontend plugins more consistent with backend plugins and allows another means for security scanners to inspect the plugin's dependencies. This change also moves functions that are shared between the backend and frontend commands into a shared utils file so it's more obvious which functions are common to each command. The .yarnrc.yml from the containing workspace is also retrieved, or a new one is created to ensure consistency when running "yarn install" during plugin export. Also workspace resolutions are taken from the adjacent package.json file when the yarn lockfile is discovered and applied to the derived exported package. This change also adds some documents that summarize the plugin export process. Finally this change adds a prepare script so that it's possible to run this command with changes from a pull request without having to perform a release for testing purposes.
Also opted to retroactively add some of the previous changes into the CHANGELOG.md along with this one as it doesn't appear to have been updated in awhile.
Fixes RHIDP-12902
Assisted-By: Cursor Desktop
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED