feat: configurable OCI registry for DPDY {{inherit}} refs in nightly mode#104
Merged
jrichter1 merged 2 commits intoMay 13, 2026
Merged
Conversation
…mode
Decouple the {{inherit}} tag registry from metadata's dynamicArtifact to
avoid registry mismatches (e.g. metadata switching from RHEC to ghcr.io
while DPDY stays on RHEC). The registry is now resolved via:
1. NIGHTLY_DPDY_OCI_REGISTRY_MAP (per-plugin JSON override)
2. NIGHTLY_DPDY_OCI_REGISTRY (blanket override)
3. Default: registry.access.redhat.com/rhdh
Also adds selective config injection in nightly: only non-DPDY OCI
plugins get appConfigExamples injected; DPDY plugins inherit config
from RHDH, and wrapper plugins get no injection.
Assisted-by: Claude Code
Co-Authored-By: Claude Code <noreply@anthropic.com>
Rewrite confusing references across docs and source comments:
- {{inherit}} tells RHDH to resolve both the OCI tag (version) AND
default config from its built-in DPDY, not just one or the other
- Replace vague "DPDY OCI plugin" with explicit "plugins in
default.packages.yaml whose metadata spec.dynamicArtifact is OCI"
- Remove redundant tests covered by existing assertions
Assisted-by: Claude Code
Co-Authored-By: Claude Code <noreply@anthropic.com>
jrichter1
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{inherit}}tag registry from metadata'sspec.dynamicArtifactto prevent registry mismatches (e.g. when metadata switches fromregistry.access.redhat.comtoghcr.iowhile DPDY stays on RHEC)NIGHTLY_DPDY_OCI_REGISTRY_MAP(per-plugin JSON) >NIGHTLY_DPDY_OCI_REGISTRY(blanket) > defaultregistry.access.redhat.com/rhdhappConfigExamplesinjected; DPDY plugins inherit config from RHDH, wrapper plugins get no injectionEnvironment Variables
NIGHTLY_DPDY_OCI_REGISTRY{{inherit}}refsghcr.io/redhat-developer/rhdh-plugin-export-overlaysNIGHTLY_DPDY_OCI_REGISTRY_MAP{"ghcr.io/custom": ["@backstage-community/plugin-tekton"]}Changes
src/utils/plugin-metadata.ts: AddedgetDpdyRegistry()function,DEFAULT_DPDY_OCI_REGISTRYconstant, updated{{inherit}}construction to use configurable registry instead of metadata-derivedsrc/utils/tests/plugin-metadata.nightly.test.ts: Added tests for registry override, per-plugin map, precedence, PR #2449 scenario,getDpdyRegistryunit testssrc/utils/tests/plugin-metadata.pr.test.ts: Added negative tests ensuring{{inherit}}and registry env vars don't apply in PR/local modeTest plan
node --test){{inherit}}refsNIGHTLY_DPDY_OCI_REGISTRY_MAPcorrectly routes specific plugins to different registriesAssisted-by: Claude Code