Skip to content

chore(app-defaults): add e2e tests#2290

Open
gashcrumb wants to merge 1 commit into
redhat-developer:mainfrom
gashcrumb:RHIDP-13043
Open

chore(app-defaults): add e2e tests#2290
gashcrumb wants to merge 1 commit into
redhat-developer:mainfrom
gashcrumb:RHIDP-13043

Conversation

@gashcrumb
Copy link
Copy Markdown
Member

This change adds some e2e tests to the app-defaults workspace that start up RHDH using the new frontend system and validates that app login and scm authentication function as expected.

Fixes RHIDP-13043

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@gashcrumb gashcrumb requested review from a team and kadel as code owners April 22, 2026 10:25
@gashcrumb
Copy link
Copy Markdown
Member Author

/publish

@github-actions
Copy link
Copy Markdown
Contributor

Publish workflow has completed with success.

Publishing process

✅ Finished successfully.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-app-auth:pr_2290__0.0.1
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-app-integrations:pr_2290__0.0.1

Backstage Compatibility Check

✅ All workspaces are compatible with the target Backstage version (1.49.4).

No action required.

Metadata Validation

✅ All metadata files validated successfully.

Running e2e tests
/test e2e-ocp-helm

@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@github-actions
Copy link
Copy Markdown
Contributor

Smoke tests workflow passed. All plugins loaded successfully.

@rhdh-test-bot
Copy link
Copy Markdown

❌ Failed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 4m 53s
Passed: 1 | Failed: 2 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Artifacts

@gashcrumb gashcrumb force-pushed the RHIDP-13043 branch 2 times, most recently from 28d7b95 to 4aca0ed Compare April 22, 2026 11:05
@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-test-bot
Copy link
Copy Markdown

❌ Failed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 4m 31s
Passed: 1 | Failed: 2 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Artifacts

@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-test-bot
Copy link
Copy Markdown

❌ Failed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 4m 35s
Passed: 2 | Failed: 1 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Artifacts

@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-test-bot
Copy link
Copy Markdown

✅ Passed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 4m 23s
Passed: 3 | Failed: 0 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Artifacts

@github-actions github-actions Bot added the workspace-update PR modifies files in an existing workspace label Apr 22, 2026
@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@gashcrumb
Copy link
Copy Markdown
Member Author

/hold

probably be good to first extend rhdh-e2e-test-utils to provide the NFS-related environment variables for a test via the setup configuration, rather than the test needing to provide them.

@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-test-bot
Copy link
Copy Markdown

✅ Passed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 4m 19s
Passed: 3 | Failed: 0 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Artifacts

@subhashkhileri
Copy link
Copy Markdown
Member

@red-hat-developer-hub/e2e-test-utils has been updated to 1.1.35 across all workspaces. Before merging, please update this PR to align:

  1. playwright.config.ts: remove import dotenv from "dotenv" and dotenv.config(...) call
  2. package.json: bump @red-hat-developer-hub/e2e-test-utils to 1.1.35, remove dotenv from devDependencies, add "test:vault": "VAULT=1 playwright test" script
  3. Run yarn install to update yarn.lock

Since v1.1.33, the e2e-test-utils global setup automatically loads .env files from each project's directory via loadDotenvFromProjects. Manual dotenv setup in playwright.config.ts is no longer needed and the dependency can be dropped.

Reference — see tech-radar workspace for the updated pattern:

@github-actions
Copy link
Copy Markdown
Contributor

The file versions.json could not be synced from branch main into this because your PR is from a fork.

You should update the versions.json file with the following content:

{
    "backstage": "1.49.4",
    "node": "22.22.0",
    "cli": "1.10.5",
    "cliPackage": "@red-hat-developer-hub/cli"
}

@github-actions
Copy link
Copy Markdown
Contributor

The file versions.json could not be synced from branch main into this because your PR is from a fork.

You should update the versions.json file with the following content:

{
    "backstage": "1.49.4",
    "node": "22.22.0",
    "cli": "1.10.6",
    "cliPackage": "@red-hat-developer-hub/cli"
}

@gashcrumb
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-test-bot
Copy link
Copy Markdown

✅ Passed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 5m 5s
Passed: 3 | Failed: 0 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Logs | Artifacts

@gashcrumb
Copy link
Copy Markdown
Member Author

Created this PR for consideration to add support for configuring the new frontend system from a test vs having to pass value files and explicit new frontend system package config.

This change adds some e2e tests to the app-defaults workspace that start
up RHDH using the new frontend system and validates that app login and
scm authentication function as expected.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud
Copy link
Copy Markdown

@gashcrumb
Copy link
Copy Markdown
Member Author

/publish
/unhold

@github-actions
Copy link
Copy Markdown
Contributor

Publish workflow has completed with success.

Publishing process

✅ Finished successfully.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-app-auth:pr_2290__0.0.2
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-app-integrations:pr_2290__0.0.2

Backstage Compatibility Check

✅ All workspaces are compatible with the target Backstage version (1.49.4).

No action required.

Metadata Validation

✅ All metadata files validated successfully.

Running e2e tests
/test e2e-ocp-helm

@github-actions
Copy link
Copy Markdown
Contributor

Smoke tests workflow passed. All plugins loaded successfully.

@rhdh-test-bot
Copy link
Copy Markdown

✅ Passed E2E Tests - app-defaults

Platform: ocp 4.18 | RHDH Version: 1.10 | Duration: 5m 17s
Passed: 3 | Failed: 0 | Flaky: 0 | Skipped: 0
Playwright Report | Build Log | Logs | Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workspace-update PR modifies files in an existing workspace

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants