Open
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Review Summary by QodoImplement Data Center UI with Environments and Service Specs Management
WalkthroughsDescription• Implemented complete Data Center UI with tabbed layout for Environments and Service Specs management • Created comprehensive CRUD operations (Create, Update, Delete) with modal dialogs for both Environments and Service Specs • Built detail pages for individual environments and service specs with tabbed navigation (Overview, Entities, Request History) • Implemented mock data structures and interfaces for Environment, ServiceSpec, entities, and request history • Added Material-UI styling system with theme-aware dark/light mode support for tables, dialogs, and detail pages • Created reusable form components (EnvironmentFormFields, ServiceSpecFormFields) and shared dialog wrapper (DcmFormDialog) • Implemented search, filtering, and pagination functionality across all table views • Added PatternFly theme synchronization hook to sync Backstage theme with PatternFly dark theme • Created plugin-level router supporting nested routing for detail pages • Added configuration schema for DCM plugin with policy packs support • Updated RHDH logo with dynamic dark theme support • All data is currently mocked as API is not yet ready Diagramflowchart LR
A["DataCenterPage<br/>Tabbed Layout"] --> B["EnvironmentsTabContent<br/>Table + CRUD"]
A --> C["ServiceSpecsTabContent<br/>Table + CRUD"]
B --> D["EnvironmentDetailsPage<br/>Overview/Entities/History"]
C --> E["ServiceSpecDetailsPage<br/>Overview/Entities/History"]
B --> F["RegisterEnvironmentDialog<br/>EnvironmentFormFields"]
B --> G["EditEnvironmentDialog<br/>EnvironmentFormFields"]
B --> H["DeleteEnvironmentDialog"]
C --> I["ServiceSpecCreateDialog<br/>ServiceSpecFormFields"]
C --> J["ServiceSpecEditDialog<br/>ServiceSpecFormFields"]
C --> K["DeleteServiceSpecDialog"]
D --> L["OverviewTab<br/>OverviewField Components"]
D --> M["EntitiesTab<br/>Filtered Table"]
D --> N["RequestHistoryTab<br/>Paginated Table"]
E --> O["SpecOverviewTab<br/>OverviewField Components"]
E --> P["SpecEntitiesTab<br/>Filtered Table"]
E --> Q["SpecRequestHistoryTab<br/>Paginated Table"]
File Changes1. workspaces/dcm/plugins/dcm/src/components/dcmTabTableStyles.ts
|
Code Review by Qodo
1. YAML tags become comments
|
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
workspaces/dcm/plugins/dcm/src/pages/data-center/EnvironmentsTabContent.tsx
Show resolved
Hide resolved
asmasarw
force-pushed
the
feature/data-center
branch
2 times, most recently
from
6706351 to
c10caa2
Compare
asmasarw
force-pushed
the
feature/data-center
branch
from
11b6529 to
5b09a9e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Data-Center UI including:
** All Data are mocked since API is NOT ready yet.
UI Images: