RHIDP-12113: Support customization aggregated homepage scorecard card#2609
Draft
imykhno wants to merge 1 commit intoredhat-developer:mainfrom
Draft
RHIDP-12113: Support customization aggregated homepage scorecard card#2609imykhno wants to merge 1 commit intoredhat-developer:mainfrom
imykhno wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Changed Packages
|
6777ebf to
67dfc04
Compare
…cards Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
67dfc04 to
6874de5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hey, I just made a Pull Request!
This PR lets system administrators customize the
titleanddescriptionshown on aggregated KPI scorecard cards viaapp-config, so Engineering and Product Managers to provide company-specific information, ensuring metrics are easily understood by end-users.Behavior
titleanddescriptionare derived from the metric definition, with the aggregation type set tostatusGroupedby default. Internationalisation (i18n) still applies ifmetric.titleormetric.descriptionare present in the plugin catalogues.app-config.yamlfile. Providingtitle,description, type andmetricIdis required to customize aggregated KPIConfiguration
Customization is not under per-provider plugin keys. It lives under scorecard.aggregationKPIs. (
app-config.yaml). The homepage wires ScorecardHomepageCard (or equivalent) withprops.aggregationIdmatching that key or the metric id for the default case.Example:
API
Responses that include aggregation metadata:
GET /aggregations/:aggregationId;GET /aggregations/:aggregationId/metadata;GET /metrics/:metricId/catalog/aggregations.New logic implemented for:
✔️ Checklist
How to test
1. Aggregated KPI (without changing)
The implemented logic supports the deprecated
metricIdprovided inmountPoints. While this logic is currently maintained to allow users to have aggregated KPIs without changing their configuration, it is scheduled for removal in a future release.metricId. Expected to use the same config as used before;Validate error messages:
2. Aggregated KPI (without default configurations)
The new logic supports the default configuration for aggregated KPI cards. Each provider has a default card information therefore, using the default setup does not require any configuration in the
app-config.yamlfile.aggregationId: 'jira.open_issues'Validate error messages:
3. Aggregated KPI (with customized title and description)
app-config.yamlunder thescorecard.aggregationKPIs. Example:app-config.yamlaggregationKPIs key. Example: aggregationId: 'aggregationKPIs' or aggregationId: 'openIssuesKpi' following the example;Validate error messages:
4. Test the
/metrics/:metricId/catalog/aggregationsendpointThis endpoint is deprecated and scheduled for removal in the next release. However, it remains available for use in the interim.
Get aggregated metric