fix: add ownership checks to promote and delete agent routes#3215
Closed
rrbanda wants to merge 1 commit into
Closed
fix: add ownership checks to promote and delete agent routes#3215rrbanda wants to merge 1 commit into
rrbanda wants to merge 1 commit into
Conversation
- On draft→review promote: verify createdBy matches caller for non-admins, preventing users from submitting other people's drafts for review - Add DELETE /agents/:agentId route that only allows deletion of draft agents, with ownership verification for non-admin callers - Add deleteAgentConfig to frontend AugmentApi interface and implementation - Add createdBy field to ChatAgentConfig (prerequisite for ownership checks) - Add agent.delete audit action type - Update report.api.md files Part of Epic redhat-developer#3208
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
Contributor
Author
|
Closing: superseded by Phase 1 (#3222) which consolidates ownership checks with createdBy persistence, phantom draft blocking, and GET scoping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draft→reviewpromote: verifiescreatedBymatches caller for non-admins, preventing users from submitting other people's drafts for reviewDELETE /agents/:agentIdroute that only allows deletion of draft agents, with ownership verification for non-admin callers (admins can delete any draft)deleteAgentConfigto frontendAugmentApiinterface and implementationcreatedByfield toChatAgentConfigtype (prerequisite for ownership checks)Part of Epic #3208
Test plan