fix: auto-switch to My Agents tab after creation and fix intent dialog reopen#3216
Closed
rrbanda wants to merge 1 commit into
Closed
fix: auto-switch to My Agents tab after creation and fix intent dialog reopen#3216rrbanda wants to merge 1 commit into
rrbanda wants to merge 1 commit into
Conversation
…g reopen After creating an agent, the user was left on the Explore tab where drafts are invisible. Now the Marketplace automatically switches to the My Agents tab so the user sees their new draft immediately. Also fixes the intent dialog reopening after image-deploy: the wizard's onClose (handleWizardBack) was triggering setIntentDialogOpen(true) even after onCreated had already closed the wizard. A ref now suppresses the reopen when an agent was just created. Part of Epic redhat-developer#3208
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
- Coverage 53.41% 53.41% -0.01%
==========================================
Files 2373 2373
Lines 84895 84905 +10
Branches 23568 23570 +2
==========================================
Hits 45349 45349
- Misses 39200 39210 +10
Partials 346 346
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing: superseded by Phase 2 (#3223) which consolidates post-create redirect, dialog fix, and role-aware buttons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onClose(handleWizardBack) was triggeringsetIntentDialogOpen(true)even afteronCreatedhad already closed the wizard. A ref now suppresses the reopen.switchToMyAgentsKeyprop toMarketplacePageto allow external tab controlPart of Epic #3208
Test plan