feat: show rejection reason to creators and add reason dialog for admins#3220
Closed
rrbanda wants to merge 2 commits into
Closed
feat: show rejection reason to creators and add reason dialog for admins#3220rrbanda wants to merge 2 commits into
rrbanda wants to merge 2 commits into
Conversation
When an admin rejects an agent (demotes review→draft), they can now provide a reason. The backend stores rejectionReason, rejectedBy, and rejectedAt on the ChatAgentConfig. These fields are cleared when the agent is re-submitted for review. Changes: - Add rejectionReason, rejectedBy, rejectedAt to ChatAgentConfig and ChatAgent interfaces - Add createdBy field to both interfaces (prerequisite for downstream PRs) - Update PUT /agents/:id/demote to accept optional 'reason' in body - Surface rejection fields through overlayConfig in unified agent list - Update demoteAgent API method to accept optional reason parameter - Update report.api.md files for both augment and augment-common Part of Epic redhat-developer#3208
- AgentLifecycleDetail now shows a warning banner when a draft agent has a rejectionReason, displaying the reason and who rejected it - ReviewQueue reject button now opens a dialog where admins can enter an optional rejection reason before confirming the rejection - The reason is passed to demoteAgent which stores it on the config Part of Epic redhat-developer#3208. Requires PR E (rejection fields).
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3220 +/- ##
=========================================
Coverage 53.41% 53.41%
=========================================
Files 2373 2373
Lines 84895 84895
Branches 23568 23573 +5
=========================================
Hits 45349 45349
+ Misses 39200 37997 -1203
- Partials 346 1549 +1203
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing: superseded by Phase 2 (#3223) which consolidates rejection UI with the full frontend lifecycle UX fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rejectionReason, displaying the reason text and who rejected itdemoteAgent(agentId, 'draft', reason)to the backendPart of Epic #3208. Depends on PR #3219 (rejection fields).
Test plan