feat(augment): Phase 4 - enterprise-grade cascading delete and lifecycle enforcement#3225
Merged
pkliczewski merged 2 commits intoMay 21, 2026
Conversation
This was referenced May 21, 2026
rrbanda
force-pushed
the
pr/lifecycle-hardening-phase4
branch
from
0654ef6 to
4fd11a1
Compare
Contributor
|
This pull request adds a new top-level directory under |
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rrbanda
force-pushed
the
pr/lifecycle-hardening-phase4
branch
from
4fd11a1 to
92a525c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3225 +/- ##
==========================================
+ Coverage 53.80% 53.82% +0.01%
==========================================
Files 2362 2362
Lines 84772 84815 +43
Branches 23497 23511 +14
==========================================
+ Hits 45612 45650 +38
- Misses 37638 38822 +1184
+ Partials 1522 343 -1179
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
rrbanda
force-pushed
the
pr/lifecycle-hardening-phase4
branch
from
92a525c to
902c791
Compare
3 tasks
rrbanda
force-pushed
the
pr/lifecycle-hardening-phase4
branch
from
902c791 to
9bbc6bb
Compare
Phase 3 of lifecycle hardening: adds 30-second polling to ReviewQueue and OpsOverview for real-time admin visibility. Key fix: only sets loading=true on the initial load, not on subsequent polls. This eliminates the skeleton flash that occurred every 30 seconds in the previous implementation (PR G). ReviewQueue: - 30s polling interval for review queue agents - initialLoadDone ref prevents loading flash on polls OpsOverview: - 30s polling interval for agent and tool data - Same loading flash fix via initialLoadDone ref
…ement
Phase 4 of lifecycle hardening: source-aware cascading delete and
lifecycle graph enforcement for publish routes.
Cascading DELETE /agents/:agentId:
- Detects agent source via unified agent list (kagenti/orchestration/workflow)
- For orchestration agents: removes from 'agents' admin config key AND
chatAgents lifecycle entry in a single operation
- For Kagenti agents: removes chatAgents entry, notes that K8s cleanup
requires the dedicated admin endpoint
- Returns detailed cleanupResults per store for transparency
- Ownership enforcement: non-admins restricted to own draft agents
Lifecycle enforcement on publish routes:
- PUT /agents/:agentId/publish: detects when admin bypasses lifecycle
stages (e.g. draft -> production), logs audit warning with
lifecycleBypassed flag, still allows the operation
- PUT /agents/bulk-publish: same bypass detection per agent, logs
warning with count of bypassed agents
OrchAgentDetailView:
- Updated handleDelete to use the cascading DELETE /agents/:agentId
endpoint instead of directly mutating admin config
- Removed unused useAdminConfig('agents') hook
rrbanda
force-pushed
the
pr/lifecycle-hardening-phase4
branch
from
9bbc6bb to
7469ed0
Compare
|
pkliczewski
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 of the Deep-Dive Lifecycle Hardening plan. Implements enterprise-grade cascading delete and lifecycle graph enforcement. Depends on Phase 3 (PR #3224).
Cascading DELETE /agents/:agentId
The delete endpoint now detects the agent's source and cleans up all relevant stores:
agentsadmin config key +chatAgentslifecycle entrychatAgentslifecycle entry. Notes K8s cleanup requires dedicated admin endpointchatAgentslifecycle entryReturns detailed
cleanupResultsper store for full transparency. Ownership enforcement: non-admins restricted to their own draft agents.Lifecycle enforcement on publish routes
PUT /agents/:agentId/publish: detects when admin bypasses lifecycle stages (e.g., draft -> production directly), logs audit warning withlifecycleBypassedflagPUT /agents/bulk-publish: same detection per agent, logs count of bypassed agentsBoth routes still allow the operation (admin override) but provide full audit trail.
OrchAgentDetailView update
handleDeletenow calls the cascadingDELETE /agents/:agentIdAPI instead of directly mutating the admin config, ensuring consistent cleanup across all storesuseAdminConfig('agents')hookTest plan
lifecycleBypassed: true